865705 - add individual permission for "needs change"

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P3)

Description

[Rosana Ardila]

To implement the new reviewer groups we need to give granular rights.

These are the rights we need:
Create a revision
Review a revision 
Add Needs Changes notes
Change an article's title, slug, category, topics and keywords
Archive an article
Mark articles ready for localization
Delete documents
Create, delete and change the visibility of products, topics and sub-topics

The actual reviewer rights are: 
archive document
change document
add revision
change revision
mark a revision ready for localization
review a revision

Can we changethe permisions on django to match our current needs?

Thanks,

Rosana

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Rosana Ardila from comment #0)
> These are the rights we need:
> Create a revision

Are we going to require users to have a permission to create a new revision? That is a big change from our current "anybody can edit" strategy.

> Review a revision

We have "wiki | revision | Can review a revision" already for this.

> Add Needs Changes notes

This one needs to be created.

> Change an article's title, slug, category, topics and keywords

We have "wiki | document | Can change document" already for this.

> Archive an article

We have "wiki | document | Can archive document" already for this.

> Mark articles ready for localization

We have "wiki | revision | Can mark revision as ready for localization" already for this.

> Delete documents

We have "wiki | document | Can delete document" already for this.

> Create, delete and change the visibility of products, topics and sub-topics

This is admin only right now, so only staff users with the right permissions can touch that.


Sounds like we just adding 1 permission for "Needs change". Is that right?

Comment 2

[Kadir Topal [:atopal]]

Ricky, yes, as far as I can tell that's what we are going for here.

Comment 3

[Rosana Ardila]

Ricky, that's right, that is the right we need to set up individually

Thanks!

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Since this is mostly the same as bug 837851 => 1pt

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1365

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/c018da821011ab73b0943caa465345c28b43611c

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.