TEF+Spain operator shelf not showing up on Stage when in Spain

RESOLVED INVALID

Status

Marketplace
Consumer Pages
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: krupa, Assigned: basta)

Tracking

Points:
---

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 741891 [details]
screenshot

I am in Spain and I think we have geolocation enabled in Spain.

We made an operator shelf for TEF+Spain and I put an app in that category. However, that category is not showing up on the homepage.
I'm not in Spain but I'm using this URL:  https://marketplace.allizom.org/?region=es&carrier=telefonica

I also don't see it.  I didn't clear memcache, but I made it yesterday, I figured it would have expired by now.  Maybe that's not the case?
Assignee: nobody → mattbasta
(Assignee)

Comment 2

5 years ago
Is it getting cut off? The categories have a stupid arbitrary limit that cuts off the last categories if they don't make a full row. If the name starts with a T, it might be alphabetically at the end and is getting cut off.

Try adjusting the category weight and clearing memcached.

IMO, we should never be truncating categories.

Can you access the category directly by its URL?
It's always been there on mobile:
https://marketplace.allizom.org/?region=es&carrier=telefonica&mobile=true&tablet=false

It's totally there: http://f.cl.ly/items/2h1V0n010S0o0j0D3Y3t/Screen%20Shot%202013-04-25%20at%209.22.36%20AM.png

We do this thing on desktop where we show categories in groups of 4 only.

I've made some other categories weight=-1, so it's visible now on desktop too:
http://f.cl.ly/items/0k0F2D1u360M3l0G1Z2b/Screen%20Shot%202013-04-25%20at%209.24.49%20AM.png

Fireplace doesn't have this issue because categories are handled via a dropdown now.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Created attachment 741900 [details]
screenshot

I just refreshed the page and I see it there now.  I didn't flush anything.  The URL works also https://marketplace.allizom.org/apps/tefnspain
Ah, collided with cvan.  So, you're saying only on desktop is there a chance that the operator shelf category won't show up (and that is temporary until we improve designs)?
(In reply to Wil Clouser [:clouserw] from comment #5)
> Ah, collided with cvan.  So, you're saying only on desktop is there a chance
> that the operator shelf category won't show up (and that is temporary until
> we improve designs)?

Exactly, we can just remove the code that groups the categories in fours. It would just look like this:

http://f.cl.ly/items/1j3V1K2z3G3I0E2E2M32/Screen%20Shot%202013-04-25%20at%209.36.43%20AM.png
Alright, np.  Let's just let that issue expire with the new designs.

Thanks for the help basta+cvan.
(Reporter)

Comment 8

5 years ago
I am on a Firefox OS phone and I have flashed and freshly installed the marketplace stage app. I don't see this category.

I have checked in two other phones and Kumar can confirm as well.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Assignee)

Comment 9

5 years ago
Is the carrier set to telefonica?
(In reply to krupa raj 82[:krupa] from comment #8)
> I am on a Firefox OS phone and I have flashed and freshly installed the
> marketplace stage app. I don't see this category.
> 
> I have checked in two other phones and Kumar can confirm as well.

I totally see it at https://marketplace.allizom.org/?region=es&carrier=telefonica&mobile=true&tablet=false

http://f.cl.ly/items/050j3q1b3t3f2m3g0A03/Screen%20Shot%202013-04-26%20at%2010.13.18%20AM.png
(Assignee)

Comment 11

5 years ago
Could this be because yule log doesn't set the carrier to telefonica?

https://github.com/mozilla/fireplace/blob/master/yulelog/index.html#L26
(In reply to krupa raj 82[:krupa] from comment #8)
> freshly installed the marketplace stage app

If they're using the Marketplace app shipped with Gaia, yes. But Krupa explicitly said "Marketplace stage."
(In reply to Chris Van Wiemeersch [:cvan] from comment #12)
> (In reply to krupa raj 82[:krupa] from comment #8)
> > freshly installed the marketplace stage app
> 
> If they're using the Marketplace app shipped with Gaia, yes. But Krupa
> explicitly said "Marketplace stage."

And as I expected, people are using Kumar's installation page which doesn't add ?carrier=telefonica when installing Stage: http://people.mozilla.org/~kmcmillan/mktdev.html

Everyone should use my page instead: http://people.mozilla.org/~cwiemeersch/mktdev.html
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.