Closed Bug 865728 Opened 7 years ago Closed 6 years ago

Center tab-label on OSX

Categories

(Firefox :: Tabbed Browser, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Whiteboard: [Australis:M3])

Attachments

(1 file, 1 obsolete file)

Steven - I got ui-r+ on bug 685059, but I recall us saying that it looked better on OSX if the labels were centered. Is that true?
If it's true we want this, then I'll try to get this into the Australis:M3 milestone (this is a trivial fix).
Flags: needinfo?(shorlander)
Ah, sorry, I thought that was part of the patch. Yes please recenter the labels on OSX. Thanks!
Flags: needinfo?(shorlander)
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #741949 - Flags: review?(dao)
Whiteboard: [Australis:M3]
No longer blocks: 685059
Depends on: 685059
Attachment #741949 - Flags: review?(dao) → review+
This got bit-rotted after I merged m-c into UX. Here's the updated patch.

Landed on UX as https://hg.mozilla.org/projects/ux/rev/5fcbdb18c301
Attachment #741949 - Attachment is obsolete: true
Attachment #742052 - Flags: review+
Whiteboard: [Australis:M3] → [Australis:M3][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/5fcbdb18c301
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M3][fixed-in-ux] → [Australis:M3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.