Closed
Bug 865767
Opened 8 years ago
Closed 8 years ago
Zoom in/out cursor not shown (regression)
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 23
Tracking | Status | |
---|---|---|
firefox22 | --- | unaffected |
firefox23 | --- | verified |
People
(Reporter: metasieben, Assigned: waterlo1)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.27 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Looks like todays Nightly is no longer displaying either zoom-in/zoom-out while viewing an image that's bigger than the current viewport.
![]() |
||
Comment 1•8 years ago
|
||
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/c3a204a6b498 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130423 Firefox/23.0 ID:20130423044135 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/e5320348d5d7 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130423 Firefox/23.0 ID:20130423052235 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c3a204a6b498&tochange=e5320348d5d7 Regressed by: 2e822e8396c2 Brandon Waterloo — Bug 862117 - Move CSS rule classes relevant to image documents for cursor appearance (zoom in / zoom out) into layout/style/ImageDocument.css. r=roc, r=jaws This stylesheet applies to all ImageDocuments, including those in frames. In old location for CSS rules, some full themes would not show cursors correctly, nor would ImageDocuments in frames. Image rotation CSS rule classes moved to layout/style/TopLevelImageDocument.css.
![]() |
||
Updated•8 years ago
|
Blocks: 862117
Keywords: regression
Assignee | ||
Comment 2•8 years ago
|
||
I think I failed to add the reference to the installer for my new CSS file. (That's jaws thought actually). I put it in the makefile but missed the installer.
Comment 3•8 years ago
|
||
Yeah, it will need to be added to http://mxr.mozilla.org/mozilla-central/source/browser/installer/package-manifest.in
Assignee: nobody → waterlo1
Status: NEW → ASSIGNED
Hardware: x86 → All
Assignee | ||
Comment 4•8 years ago
|
||
This ought to fix it. I also grepped for any other places where "TopLevelImageDocument.css" is and couldn't find any that we hadn't already covered, so I think this should do it.
Attachment #742297 -
Flags: review?(jaws)
Updated•8 years ago
|
Attachment #742297 -
Flags: review?(jaws) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6de91faf60a
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d6de91faf60a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
status-firefox22:
--- → unaffected
status-firefox23:
--- → fixed
Updated•8 years ago
|
tracking-firefox23:
? → ---
Comment 8•8 years ago
|
||
I confirm the fix is verified on Windows 7 x64, Mac OS 10.7.5 and Ubuntu 13.04 x86 using FF 23b8. Build ID: 20130722172257
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•