Closed Bug 865788 Opened 7 years ago Closed 7 years ago

Pressing ESC should close the sidebar in Scratchpad

Categories

(DevTools :: General, defect, P3)

21 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bbenvie, Assigned: bbenvie)

References

Details

Attachments

(1 file, 1 obsolete file)

There's currently no way to close the sidebar VariablesView once opened in either the Scratchpad or the WebConsole. At the very least, I would expect pressing Escape should allow me to close the sidebar.
Yes, I've wanted this, too.
Attached patch WIP1 (obsolete) — Splinter Review
First crack at this. Right now I'm just hard coding in the key as VK_ESCAPE, following the example of VK_F1 for help. I'm wondering if I should do this or not though.

Although, this patch only adds this for Scratchpad. I'm thinking the webconsole should be a different patch since it seems that there may already be more appropriate bugs.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Flags: needinfo?
Attached patch WIP2Splinter Review
Remove accidentally left in commented out lines.
Attachment #742531 - Attachment is obsolete: true
Flags: needinfo?
Priority: -- → P3
Comment on attachment 742532 [details] [diff] [review]
WIP2

I'm a just r+ that right now.
Attachment #742532 - Flags: review+
Whiteboard: [land-in-fx-team]
Summary: Press ESC should close the sidebar in Scratchpad and (maybe) WebConsole → Pressing ESC should close the sidebar in Scratchpad and (maybe) WebConsole
Summary: Pressing ESC should close the sidebar in Scratchpad and (maybe) WebConsole → Pressing ESC should close the sidebar in Scratchpad
https://hg.mozilla.org/integration/fx-team/rev/792b835f943d
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.