865867 - Remove all perf code from core Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

We have a bunch of unused perf code in Marionette that formed the basis of an early attempt at supporting performance tests.

We should remove all this; perf metrics should be generated using app-specific logic, like that in https://github.com/mozilla/b2gperf/.  If we want to provide some generic perf framework in the future, we should probably create a mixin for it.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Remove unused perf code from Marionette,

Will run this on try.

Comment 2

[Jonathan Griffin (:jgriffin)]

try: https://tbpl.mozilla.org/?tree=Try&rev=1c461ff07472

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 742110 [details] [diff] [review]
Remove unused perf code from Marionette,

try was green

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 742110 [details] [diff] [review]
Remove unused perf code from Marionette,

Review of attachment 742110 [details] [diff] [review]:
-----------------------------------------------------------------

good riddance!

::: testing/marionette/client/setup.py
@@ +1,4 @@
>  import os
>  from setuptools import setup, find_packages
>  
> +version = '0.5.25'

Version number has changed since this patch was uploaded

Comment 5

[Jonathan Griffin (:jgriffin)]

(In reply to Malini Das [:mdas] from comment #4)
> >  
> > +version = '0.5.25'
> 
> Version number has changed since this patch was uploaded

Yeah I noticed.  I decided to bump the version with bug 865859 instead of here, just because I'm landing that after this and didn't feel 2 version bumps in one day was really necessary.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7cea777341

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ff7cea777341

Comment 7

[Jonathan Griffin (:jgriffin)]

checkin-needed for mozilla-b2g18 please

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/ee0e5d131ca3

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/92e6ac954d90