Remove all perf code from core Marionette

RESOLVED FIXED in Firefox 23

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

We have a bunch of unused perf code in Marionette that formed the basis of an early attempt at supporting performance tests.

We should remove all this; perf metrics should be generated using app-specific logic, like that in https://github.com/mozilla/b2gperf/.  If we want to provide some generic perf framework in the future, we should probably create a mixin for it.
Will run this on try.
Comment on attachment 742110 [details] [diff] [review]
Remove unused perf code from Marionette,

try was green
Attachment #742110 - Flags: review?(mdas)
Comment on attachment 742110 [details] [diff] [review]
Remove unused perf code from Marionette,

Review of attachment 742110 [details] [diff] [review]:
-----------------------------------------------------------------

good riddance!

::: testing/marionette/client/setup.py
@@ +1,4 @@
>  import os
>  from setuptools import setup, find_packages
>  
> +version = '0.5.25'

Version number has changed since this patch was uploaded
Attachment #742110 - Flags: review?(mdas) → review+
(In reply to Malini Das [:mdas] from comment #4)
> >  
> > +version = '0.5.25'
> 
> Version number has changed since this patch was uploaded

Yeah I noticed.  I decided to bump the version with bug 865859 instead of here, just because I'm landing that after this and didn't feel 2 version bumps in one day was really necessary.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7cea777341
https://hg.mozilla.org/mozilla-central/rev/ff7cea777341
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
checkin-needed for mozilla-b2g18 please
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.