make nsSVGTextFrame2::mPositioningDirty and mPositioningUsesPercentages SVG frame state bits

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: heycam, Assigned: longsonr)

Tracking

Trunk
mozilla24
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We could save a bit of space by moving mPositioningDirty into the frame state bitfield.
Summary: make nsSVGTextFrame2::mPositioningDirty an SVG frame state bit → make nsSVGTextFrame2::mPositioningDirty and mPositioningUsesPercentages SVG frame state bits
(Assignee)

Comment 1

6 years ago
Created attachment 766395 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #766395 - Flags: review?(cam)
(Reporter)

Comment 2

6 years ago
Comment on attachment 766395 [details] [diff] [review]
patch

r=me if you

* name it NS_STATE_SVG_POSITIONING_MAY_USE_PERCENTAGES
* preserve the documentation I added for mPositioningDirty and mPositioningMayUsePercentages somewhere (either above the #defines, or maybe somewhere in nsSVGTextFrame2.h still)
Attachment #766395 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/d53ba2cc5337
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.