Closed Bug 865993 Opened 8 years ago Closed 8 years ago

for images that get layerized Draw is never called on them, but rather GetImageContainer so they don't get marked as visible

Categories

(Core :: ImageLib, defect)

Product:
Core
Component:
ImageLib
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23
Tracking Flags:
Tracking Status
firefox22 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

patch
3.15 KB, patch
joe
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
So we should send the same OnUnlockedDraw notification from GetImageContainer if the image is not locked.
Attachment #742218 - Flags: review?(joe)
Attachment #742218 - Flags: review?(joe) → review+
Comment on attachment 742218 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 689623
User impact if declined: dynamically added images that get their own layers (meeting some conditions including having opacity or an active transform) won't animate
Testing completed (on m-c, etc.): just landed on inbound now
Risk to taking this patch (and alternatives if risky): this is a relatively safe patch, I think the risk of not taking it is higher than the risk of taking it
String or IDL/UUID changes made by this patch: none
Attachment #742218 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6255ed636db1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment on attachment 742218 [details] [diff] [review]
patch

Early enough in the cycle to take a fix for what is yet to be deemed a critical release issue.
Attachment #742218 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.