865993 - for images that get layerized Draw is never called on them, but rather GetImageContainer so they don't get marked as visible

Status: RESOLVED FIXED

Description

[Timothy Nikkel (:tnikkel)]

Created attachment 742218 [details] [diff] [review]
patch

So we should send the same OnUnlockedDraw notification from GetImageContainer if the image is not locked.

Comment 1

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6255ed636db1

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 742218 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 689623
User impact if declined: dynamically added images that get their own layers (meeting some conditions including having opacity or an active transform) won't animate
Testing completed (on m-c, etc.): just landed on inbound now
Risk to taking this patch (and alternatives if risky): this is a relatively safe patch, I think the risk of not taking it is higher than the risk of taking it
String or IDL/UUID changes made by this patch: none

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6255ed636db1

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 742218 [details] [diff] [review]
patch

Early enough in the cycle to take a fix for what is yet to be deemed a critical release issue.

Comment 5

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/795edee27c88