866024 - nsWifiMonitorGonk reports no wireless access points.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

The WifiMonitor interface is supposed to notify listeners about changes in available access points. nsWifiMonitorGonk has a bug where the listeners are always notified with an empty array of access points because the array is cleared.

http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiMonitorGonk.cpp#154
and
http://mxr.mozilla.org/mozilla-b2g18/source/netwerk/wifi/nsWifiMonitorGonk.cpp#154

the call to ReplaceArray results in the second argument being cleared, which is then used to calculate the list of access points to send to listeners.

Fix coming up.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 778235
User impact if declined: 
I'm not sure, but NetworkGeolocationProvider may be incorrect.

Testing completed: 
The patch does let listeners know the correct list of access points, whereas it reported none before.

Risk to taking this patch (and alternatives if risky): 
Low, its a two line variable name fix

String or UUID changes made by this patch:
None

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9edc1d55aff5

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9edc1d55aff5