86603 - BERBitString(BitSet value) {} intialisized not all parameters

Status: RESOLVED WONTFIX

(Directory Graveyard :: LDAP Java SDK, defect)

Description

[Bernd.Kunze]

In 
package netscape.ldap.ber.stream;

public class BERBitString extends BERElement {
...
    public BERBitString(BitSet value) {
        m_value = value;
    }
...
}

I miss the initialisation of the parameter "m_value_num_bits". 
It should be like:

    public BERBitString(BitSet value) {
        m_value = value;
	m_value_num_bits = m_value.size();
    }

Comment 1

[Mark Smith [:mcs]]

Reassigned to Miodrag (Java LDAP SDK lead engineer).

Comment 2

[miodrag]

*** Bug 86604 has been marked as a duplicate of this bug. ***

Comment 3

[Soeren Unruh]

Attachment: Patch, v1

Created patch file.

Comment 4

[Mark Smith [:mcs]]

Comment on attachment 111292 [details] [diff] [review]
Patch, v1

Miodrag should be the one to review this....

Comment 5

[Frank Wein [:mcsmurf]]

Bernd.Kunze: You need someone else for reviewing this patch, miodrag isn't
working on Mozilla anymore (former Netscape). The patch hasn't bitrottened so,
so it can be reviewed.

Comment 6

[Mark Smith [:mcs]]

Reassign LDAP JDK bugs owned by Miodrag ([e-mail]) to
E-Y ([e-mail])

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 111292 [details] [diff] [review]
Patch, v1

removing [very] old review request, please re-request from someone if
applicable.

If you need to contact me specifically please add |Callek| to CC

Comment 8

[Erhyuan Tsai]

The comments above that suggested not to use BitSet.size().

 * This class is for the BitString object. Note that the BitSet class
 * has a bug: size() returns the size of the internal allocated memory
 * rather than the number of bits. Current work-around is to maintain
 * the number of bits ourselves in m_value_num_bits.
 * Change is required when BitSet is fixed.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Not activity for at least 6 years, closing.