If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add a screenshot button to the desktop-helper.

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 742319 [details] [diff] [review]
Patch

I found that useful when it is times to takes screenshots for UX.
Attachment #742319 - Flags: review?(kgrandon)
Hmm, we have to think of where we draw the line - though this is a pretty light patch, we don't want the panel getting too bloated.

Generally I would advocate letting this be it's own standalone plugin, though admittedly plugins are difficult to keep with our current profile situation. It also appears that most of the screenshot plugins are not seriously maintained, see: https://addons.mozilla.org/en-US/firefox/addon/screengrab/

I am just on the fence about this right now - but perhaps we can land it as we can always back out later should the UI become too bloated.
(In reply to Kevin Grandon :kgrandon from comment #1)
> Hmm, we have to think of where we draw the line - though this is a pretty
> light patch, we don't want the panel getting too bloated.
> 
> Generally I would advocate letting this be it's own standalone plugin,
> though admittedly plugins are difficult to keep with our current profile
> situation. It also appears that most of the screenshot plugins are not
> seriously maintained, see:
> https://addons.mozilla.org/en-US/firefox/addon/screengrab/
> 
> I am just on the fence about this right now - but perhaps we can land it as
> we can always back out later should the UI become too bloated.

As I said I found it convenient. Let's remove it later it the panel is too bloated but let makes it easy and handful for now (this is my 2 cents).
Actually this totally makes sense as it's hardware buttons that the phone supports. If possible I'd prefer to add a hardware button that's something like home + sleep button presses and have the system app handle the screenshot. Let me experiment with your patch.
Ah, I see that the current screenshot logic is in shell.js. Yet another argument to see if we can embed or share code with it somehow. In this case, I think the approach is good.
Attachment #742319 - Flags: review?(kgrandon) → review+
https://github.com/vingtetun/gaia/commit/142dda6dfe500479c8cfba2bdcd3244b70434ea9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.