about:plugins changing header page (enhancement)

VERIFIED FIXED in mozilla23

Status

()

Core
Plug-ins
P3
enhancement
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: tiziana, Assigned: mga)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bsmedberg][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
1. Open Firefox
2. Go to about:plugins page
3. The header says "Enabled plugins"

Expected Result: 
Given that in that page are listed plugins with state enabled/disabled couldn't be better the header "Installed plugins" or a separation between enabled and disabled plugins?.
Evilpie, wasn't this part of my review comments at https://bugzilla.mozilla.org/show_bug.cgi?id=661961#c8 ?
Priority: -- → P3
Whiteboard: [mentor=bsmedberg][good first bug]
(Assignee)

Comment 2

4 years ago
Hi, I would be interested in realizing this enhancement, is the page written in HTML5 + JavaScript? What IRC channel do I need to join in order to talk further about what needs to be done?
I can start tomorrow :)
Assignee: nobody → alastra.mariagrazia
(Assignee)

Comment 3

4 years ago
Created attachment 742727 [details] [diff] [review]
Change two labels in plugins.properties, replacing "enabled" with "installed"
Attachment #742727 - Flags: review?(benjamin)
Comment on attachment 742727 [details] [diff] [review]
Change two labels in plugins.properties, replacing "enabled" with "installed"

Somewhere in our localization guidelines it says that when you change the meaning of a string (such as enabledplugins_label in this case) you should change the string name also. I think you should change the name to installedplugins_label (ditto nopluginsareinstalled_label).
Attachment #742727 - Flags: review?(benjamin) → review-
(Assignee)

Comment 5

4 years ago
Created attachment 743704 [details] [diff] [review]
Change two labels and their names in plugins.properties, replacing "enabled" with "installed"

Now I changed also the label names.
Attachment #742727 - Attachment is obsolete: true
Attachment #743704 - Flags: review?(benjamin)
Attachment #743704 - Flags: review?(benjamin) → review+
Thanks for the patch!
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/52669c3bc4a0
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/52669c3bc4a0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
I confirm this is fixed on Latest Nightly on Windows 7 x64, Mac OS 10.8.3 and Ubuntu 12.10:

Build ID:20130501085824
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.