Refactor SSO client-side code

RESOLVED INVALID

Status

RESOLVED INVALID
6 years ago
5 years ago

People

(Reporter: sedge, Assigned: sedge)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The current implementation of SSO on the client-side does not take advantage of all of Persona's built-in functionality, and has some redundancies that make the code more confusing to read through.
You're planning on doing this today?
(Assignee)

Comment 2

6 years ago
:beltzner - Yes.
(Assignee)

Comment 3

6 years ago
I misspoke in the description: The Persona functionality is good, but there was some redundant code.
Comment on attachment 742519 [details] [review]
Pullr request for this patch

I'm not sure why this code is redundant - if you can let me know why then I'm cool.
Attachment #742519 - Flags: review?(ross) → review-
(Assignee)

Comment 6

6 years ago
Comment on attachment 742519 [details] [review]
Pullr request for this patch

:booze - In my walkthrough of the code it looked like that particular variable is never used.  I may have missed it though!  Here's the one I know is used: https://github.com/mozilla/login.webmaker.org/pull/25/files#L1R8
Whiteboard: u=dev c=login p=1 s=2013w17 → u=dev c=login p=1 s=2013w18
:sedge - I think you might be right.

I've made a few nit pick comments - fix those, assign me for review and we will get this landed.

Thanks for checking over the code
(Assignee)

Comment 8

6 years ago
Comment on attachment 742519 [details] [review]
Pullr request for this patch

Ready!
Attachment #742519 - Flags: review- → review?(ross)
(Assignee)

Comment 9

6 years ago
Comment on attachment 742519 [details] [review]
Pullr request for this patch

https://github.com/mozilla/login.webmaker.org/pull/25
Attachment #742519 - Flags: review?(david.humphrey)
Comment on attachment 742519 [details] [review]
Pullr request for this patch

Initial pass with comments in PR.
Attachment #742519 - Flags: review?(david.humphrey) → review-
(Assignee)

Comment 11

6 years ago
Comment on attachment 742519 [details] [review]
Pullr request for this patch

See this comment: https://github.com/mozilla/login.webmaker.org/pull/25#issuecomment-17267271
Attachment #742519 - Flags: review?(ross)
Attachment #742519 - Flags: review-
Whiteboard: u=dev c=login p=1 s=2013w18 → u=dev c=login p=1 s=2013w19
Whiteboard: u=dev c=login p=1 s=2013w19 → u=dev p=1 s=2013w19
Unless this is urgent, let's remove from this week's priorities.
Whiteboard: u=dev p=1 s=2013w19
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.