Closed Bug 866092 Opened 11 years ago Closed 11 years ago

Refactor SSO client-side code

Categories

(Webmaker Graveyard :: Login, defect)

Product:
Webmaker Graveyard
Component:
Login
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: sedge, Assigned: sedge)

Details

Attachments

(1 file)

Pullr request for this patch
53 bytes, text/x-github-pull-request
Details | Review 
The current implementation of SSO on the client-side does not take advantage of all of Persona's built-in functionality, and has some redundancies that make the code more confusing to read through.
You're planning on doing this today?
:beltzner - Yes.
I misspoke in the description: The Persona functionality is good, but there was some redundant code.
Comment on attachment 742519 [details] [review]
Pullr request for this patch

I'm not sure why this code is redundant - if you can let me know why then I'm cool.
Attachment #742519 - Flags: review?(ross) → review-
Comment on attachment 742519 [details] [review]
Pullr request for this patch

:booze - In my walkthrough of the code it looked like that particular variable is never used.  I may have missed it though!  Here's the one I know is used: https://github.com/mozilla/login.webmaker.org/pull/25/files#L1R8
Whiteboard: u=dev c=login p=1 s=2013w17 → u=dev c=login p=1 s=2013w18
:sedge - I think you might be right.

I've made a few nit pick comments - fix those, assign me for review and we will get this landed.

Thanks for checking over the code
Comment on attachment 742519 [details] [review]
Pullr request for this patch

Ready!
Attachment #742519 - Flags: review- → review?(ross)
Comment on attachment 742519 [details] [review]
Pullr request for this patch

https://github.com/mozilla/login.webmaker.org/pull/25
Attachment #742519 - Flags: review?(david.humphrey)
Comment on attachment 742519 [details] [review]
Pullr request for this patch

Initial pass with comments in PR.
Attachment #742519 - Flags: review?(david.humphrey) → review-
Comment on attachment 742519 [details] [review]
Pullr request for this patch

See this comment: https://github.com/mozilla/login.webmaker.org/pull/25#issuecomment-17267271
Attachment #742519 - Flags: review?(ross)
Attachment #742519 - Flags: review-
Whiteboard: u=dev c=login p=1 s=2013w18 → u=dev c=login p=1 s=2013w19
Whiteboard: u=dev c=login p=1 s=2013w19 → u=dev p=1 s=2013w19
Unless this is urgent, let's remove from this week's priorities.
Whiteboard: u=dev p=1 s=2013w19
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: