Closed Bug 866094 Opened 7 years ago Closed 7 years ago

add ability in mozinfo to determine if the build is asan

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: jmaher, Assigned: jmaher)

Details

Attachments

(1 file)

I would like to replace (http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#515):
automation.IS_DEBUG_BUILD

with mozinfo, maybe something like:
mozinfo.isDebug
writemozinfo.py already sticks a .debug field in there:
http://mxr.mozilla.org/mozilla-central/source/config/writemozinfo.py#78

You can add any other fields you like using writemozinfo.py. mozinfo on its own has no way to get this information.
hmm, so maybe I should be using mozinfo.json instead of 'import mozinfo'.  What would be preferred in our core test harnesses as we move towards mozbase?
We need to use mozinfo.json. There's just no way for mozinfo to determine most of this information, it has to get it from the build system. We should figure out how to better integrate mozinfo.json so that harnesses don't have to resort to hacks like the xpcshell harness does.
great, I got the debug stuff from mozinfo.json, this is sort of cool!
Summary: add ability in mozinfo to determine if the build is debug or opt → add ability in mozinfo to determine if the build is asan
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #746390 - Flags: review?(ted)
Comment on attachment 746390 [details] [diff] [review]
add asan to mozinfo.json (1.0)

Review of attachment 746390 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. We should really rewrite writemozinfo.py to use the new buildconfig module, since that'd be much simpler:
http://mxr.mozilla.org/mozilla-central/source/config/expandlibs_config.py
Attachment #746390 - Flags: review?(ted) → review+
If such a re-write does happen, I'd like it if whoever did it could also add all the other interpolated values in automation.py.in. We'll need to do this at some point before we can finish porting mochitests to mozbase.
That's mostly bug 746546. We'll need to figure out how to feed automation.py the default app path, which is bug 855262.
https://hg.mozilla.org/mozilla-central/rev/74c461118efb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.