866109 - [Camera] Camera app consumes more time between two image captures

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Leo]

1. Title : Camera app consumes more time between two image captures.
2. Precondition : Camera app should be working
3. Tester's Action : (1) Open Camera -> Take a picture -> Again take a picture
4. Detailed Symptom (ENG.) : Camera app consumes more time between two image captures. There is delay introduced when an image is captured from camera app.
5. Expected : time interval between two image capture should minimized.
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: ebe478501f151c13ce6e4cd2d0c7f4a84db191f1
9.Personal email id: [e-mail]

Comment 1

[Leo]

As per our analysis, one of the reasons for time consuming between two image captures can be: Filmstrip creation and addition of thumbnails to filmstrip.

Filmstrip sequence can be modified in such a way that it will not consume much time between image captures.

Also, providing an option to user to enable or disable filmstrip can be a good idea.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

There is also a short (500ms) preview pause in camera.js:
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/camera.js#L147

Comment 3

[Leo]

Attachment: Pointer to Pull request

As there is no auto or quick review after Image capture from camera, I am setting "PREVIEW_PAUSE" to 0 (zero).

After setting PREVIEW_PAUSE to 0, camera preview restarts faster after taking a picture.

Also, sequence of filmstrip can be changed to increase the performance between two image captures.

Comment 4

[Alex Keybl [:akeybl]]

If you'd like to request a new performance blocking criteria, please get in touch with the Mozilla perf team.

Comment 5

[Dale Harvey (:daleharvey)]

> As there is no auto or quick review after Image capture from 
> camera, I am setting "PREVIEW_PAUSE" to 0 (zero).

Thats exactly what the PREVIEW_PAUSE is a short review of the photo that was previously, its obviously in there on purpose, needinfoing UX to see if we want to take that out.

Comment 6

[Stephany Wilkes]

Changing needinfo to Francis for a quick check on whether we should take this functionality out.

Comment 7

[Hubert Figuiere [:hub]]

Is this specific to the Leo device? I can't reproduce it on Unagi.

Comment 8

[Francis Djabri [:djabber]]

I can't see the preview on Unagi either. However, if we have the film strip, I don't  see the need for the preview in any case, as the strip gives the user the ability to review her images if she wants.

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 743477 [details]
Pointer to Pull request

Sorry for the delay on this, I wasnt comfortable making ux decisions without consultation.

This is good to merge now, but we should remote |restartPreview| and replace the single call to it with |resumePreview| as its pointless without the timer, also there is a timer we store that can go away.

Again this patch has a mode change that should be removed

---
 apps/camera/js/camera.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 apps/camera/js/camera.js

These need to be checked before opening pull requests

Comment 10

[Hubert Figuiere [:hub]]

Do you need help in addressing Dale's comments so we can land these changes?

Thanks

Comment 11

[Dale Harvey (:daleharvey)]

I will redo

Comment 12

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Comment 13

[David Flanagan [:djf]]

Comment on attachment 759575 [details]
Pointer to GH

r=djf for github commit d168091

There is still a noticeable delay while the camera preview comes back (on Unagi, anyway). In the future it would be nice to fill that time with something.  Like put a white border around the captured image and show animating into the filmstrip or something. We'd want to just decode the EXIF preview and not the entire captured image itself, however.

Comment 14

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/a5a07800147969b01236d64499d27d9f55debc5b

Comment 15

[Leo]

Please uplift the patch to v1-train

Comment 16

[Dale Harvey (:daleharvey)]

For a patch to be uplifted it needs to be nommed, nomming now

Comment 18

[Alex Keybl [:akeybl]]

Not a regression, and there are no new perf requirements in 1.1. Not a blocker.