Closed Bug 866135 Opened 8 years ago Closed 8 years ago

Contacts: Fully integrate PhonenumberJS when we save contacts

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: reuben, Assigned: gwagner)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(2 files, 2 obsolete files)

patch
6.85 KB, patch
reuben
: review+
Details | Diff | Splinter Review
b2g18 patch
6.49 KB, patch
Details | Diff | Splinter Review 
No description provided.
Attached patch Normalize search.tel (obsolete) — — Splinter Review 
We don't need to store both versions because filterValue was being normalized before searching. Also includes some cleanup of makeImport.
Attachment #742399 - Flags: review?(anygregor)
Attachment #742399 - Flags: review?(anygregor)
Attached patch Normalize search.tel (obsolete) — — Splinter Review
Attachment #742399 - Attachment is obsolete: true
Attachment #742401 - Flags: review?(anygregor)
Attachment #742401 - Attachment is obsolete: true
Attachment #742401 - Flags: review?(anygregor)
Summary: Contacts: |search.tel| should be normalized → Contacts: Fully integrate PhonenumberJS when we save contacts
Attached patch patch — — Splinter Review
Blocks: b2g-contact
Blocks: 859185
We didn't fully integrate PhoneNumberJS when saving contacts. The problem is when we import contacts from other sources like google or facebook. The numbers can contain random spaces that we can't enter with our keyboard.
This patch allows us to handle lookups for such contacts correctly.
blocking-b2g: --- → leo?
Assignee: reuben.bmo → anygregor
Attachment #742450 - Flags: review?(reuben.bmo)
Comment on attachment 742450 [details] [diff] [review]
patch

Review of attachment 742450 [details] [diff] [review]:
-----------------------------------------------------------------

This is a happy day for ContactDB.makeImport! :)
Attachment #742450 - Flags: review?(reuben.bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/7a271620a508
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Duplicate of this bug: 865164
Blocks: 862742
Blocks: 864695
Blocking a blocker => leo+
blocking-b2g: leo? → leo+
This is going to need a branch-specific patch for uplift.
Flags: needinfo?(anygregor)
Attached patch b2g18 patch — — Splinter Review
Flags: needinfo?(anygregor)
Duplicate of this bug: 857460
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.