866241 - Fix some issues with repo manifest parsing

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

I tested actually hooking up the repo manifest parsing support in symbolstore.py today, and found that it had a few issues. This patch fixes them, and I'm able to get useful VCS-mangled filenames out of it.

First, some remote URLs in the manifest don't end with slashes, which makes urljoin do the wrong thing.

Second, bug 795360 broke the way this worked because it runs the symbol dumping in separate worker processes, so the global srcdirRepoInfo dict isn't actually set in the workers. I changed that to be a Manager.dict so that it can be proxied across all processes.

I'll file a separate gonk_misc PR with the change to actually hook this up.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Fix some issues with repo manifest parsing

Comment 2

[(not currently active) Ted Mielczarek]

https://github.com/mozilla-b2g/gonk-misc/pull/85

Comment 3

[(not currently active) Ted Mielczarek]

Socorro changes to handle git.mozilla.org URLs:
https://github.com/mozilla/socorro-crashstats/pull/330
https://github.com/mozilla/socorro/pull/1207

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b526c0d0b58

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2b526c0d0b58