Fix some issues with repo manifest parsing

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I tested actually hooking up the repo manifest parsing support in symbolstore.py today, and found that it had a few issues. This patch fixes them, and I'm able to get useful VCS-mangled filenames out of it.

First, some remote URLs in the manifest don't end with slashes, which makes urljoin do the wrong thing.

Second, bug 795360 broke the way this worked because it runs the symbol dumping in separate worker processes, so the global srcdirRepoInfo dict isn't actually set in the workers. I changed that to be a Manager.dict so that it can be proxied across all processes.

I'll file a separate gonk_misc PR with the change to actually hook this up.
Created attachment 742511 [details] [diff] [review]
Fix some issues with repo manifest parsing
Attachment #742511 - Flags: review?(catlee)
Component: Build Config → Breakpad Integration
Depends on: 774780
Product: Core → Toolkit
Attachment #742511 - Flags: review?(catlee) → review+
https://hg.mozilla.org/mozilla-central/rev/2b526c0d0b58
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.