Closed
Bug 866289
Opened 11 years ago
Closed 10 years ago
Clean up vim modelines in js/xpconnect
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: bholley, Assigned: poiru)
Details
(Whiteboard: [mentor=bholley])
Attachments
(2 files, 2 obsolete files)
39.34 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
4.04 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
XPConnect uses 4-space indenting (like the JS engine), which gets tricky when switching back and forth to the rest of Gecko (which uses 2-space indenting). I believe the correct modeline here is: vim: set ts=8 sts=4 et sw=4 tw=80: We should add these to the files in js/xpconnect/src, js/xpconnect/wrappers, and js/xpconnect/loader.
Comment 1•11 years ago
|
||
See bug 860029 for modeline standardization in the JS engine. sstangl probably has some scripts around to do the conversion.
Comment 2•11 years ago
|
||
We should use tw=99 to match SM.
Comment 3•11 years ago
|
||
This is my first patch. Could you(Bholley) please review it?
Updated•11 years ago
|
Attachment #784929 -
Flags: review?(bobbyholley+bmo)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 784929 [details] [diff] [review] Patch to fix bug 866289 Review of attachment 784929 [details] [diff] [review]: ----------------------------------------------------------------- Bouncing to Ms2ger, who's more likely to spot problems and knows more about modelines than I do.
Attachment #784929 -
Flags: review?(bobbyholley+bmo) → review?(Ms2ger)
Comment 5•11 years ago
|
||
This ends up still being pretty messy... IMO, all the C++ files should have /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* vim: set ts=8 sts=4 et sw=4 tw=99: */ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
Comment 6•11 years ago
|
||
Hi, Which C++ files are you referring to? I have added those lines to all C++ files in the above specified folders.
Comment 7•11 years ago
|
||
Your patch seems to use merged comments, rather than the three separate comments I suggested.
Comment 8•11 years ago
|
||
Sorry for the delay. Please review.
Attachment #784929 -
Attachment is obsolete: true
Attachment #784929 -
Flags: review?(Ms2ger)
Attachment #801131 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 9•10 years ago
|
||
Assignee: nobody → birunthan
Attachment #801131 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #801131 -
Flags: review?(Ms2ger)
Attachment #8401326 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8401328 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 11•10 years ago
|
||
Review ping.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment 12•10 years ago
|
||
Comment on attachment 8401326 [details] [diff] [review] Make mode lines consistent in js/xpconnect/ for 4 space indented files Review of attachment 8401326 [details] [diff] [review]: ----------------------------------------------------------------- r=me. In the future, please make sure that your patches have 8 lines of context.
Attachment #8401326 -
Flags: review?(Ms2ger) → review+
Comment 13•10 years ago
|
||
Comment on attachment 8401328 [details] [diff] [review] Make mode lines consistent in js/xpconnect/ for 2 space indented files Review of attachment 8401328 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8401328 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 14•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf294d2257f https://hg.mozilla.org/integration/mozilla-inbound/rev/2d59f550103f
Keywords: checkin-needed
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2cf294d2257f https://hg.mozilla.org/mozilla-central/rev/2d59f550103f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•