866342 - NS_ERROR_FAILURE in xpcIJSWeakReference.get

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

On running a gaia-ui-test, I once got this stack trace:

  File "/home/jgriffin/mozilla-inbound/src/testing/marionette/client/marionette/marionette.py", line 623, in find_element
    response = self._send_message('findElement', 'value', **kwargs)
  File "/home/jgriffin/mozilla-inbound/src/testing/marionette/client/marionette/marionette.py", line 342, in _send_message
    self._handle_error(response)
  File "/home/jgriffin/mozilla-inbound/src/testing/marionette/client/marionette/marionette.py", line 403, in _handle_error
    raise MarionetteException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_marketplace_login.py TestMarketplaceLogin.test_login_marketplace | MarionetteException: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [xpcIJSWeakReference.get]

We probably need to wrap all of our xpcIJSWeakReference.get() calls in try/catch blocks.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Use try/catch around weakref.get(),

Comment 2

[Jonathan Griffin (:jgriffin)]

try: https://tbpl.mozilla.org/?tree=Try&rev=00cf824814dc

Comment 3

[Jonathan Griffin (:jgriffin)]

try is green

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 743175 [details] [diff] [review]
Use try/catch around weakref.get(),

Review of attachment 743175 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9828d3c19f47

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9828d3c19f47

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/628abe4ef9fe

Comment 8

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/70d09baa2b80