866383 - check box missing in column mode of add-on Adblock Plus

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Fubuki Hoshino]

Attachment: Adblock_Plus_Filter_Preferences_2013-04-27_15-39-55.png

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20130426 Firefox/22.0
Build ID: 20130426004017

Steps to reproduce:

Opening adblock plus filter preference panel in order to enable/disable a filter


Actual results:

The check box is not displayed in the column mode in adblock plus filters, thus I can not enable/disable a filter.


Expected results:

The check box should be displayed.

Comment 1

[Loic]

Regression range:
good=2013-03-04
bad=2013-03-05
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=86c98c4d36da&tochange=015da7030aab

Comment 2

[Alice0775 White]

This problem is caused by Bug 407956.
So, the addon should be modified.

Comment 3

[Alex Keybl [:akeybl]]

Wladimir - do you accept Mozilla bugs?

Comment 4

[Wladimir Palant]

I do. I was looking into that issue already - thank you for tracking down the relevant API change.

Comment 5

[Wladimir Palant]

Fixed:
https://hg.adblockplus.org/adblockplus/rev/083875fc8475
https://hg.adblockplus.org/abpwatcher/rev/a0a73f6e3696

The corresponding releases should be out by next Tuesday.

Comment 6

[Wladimir Palant]

Adblock Plus 2.2.4 and Diagnostics 1.2.4 for Adblock Plus were released yesterday, that issue should be gone in both.

Comment 7

[Loic]

Attachment: checkbox-screenshot

Wladimir, do you know if the new style of the checkboxes on the right is normal after your modification?

Comment 8

[Wladimir Palant]

The checkbox style was always like that. Firefox doesn't style checkboxes in a tree widget at all, so you cannot have native styling. Adblock Plus uses checkbox images that look ok-ish on all platforms but don't match the native widgets on any platform of course.

Comment 9

[Alex Keybl [:akeybl]]

(In reply to Wladimir Palant from comment #5)
> Fixed:
> https://hg.adblockplus.org/adblockplus/rev/083875fc8475
> https://hg.adblockplus.org/abpwatcher/rev/a0a73f6e3696
> 
> The corresponding releases should be out by next Tuesday.

Untracking given this. Thanks Wladimir.