The default bug view has changed. See this FAQ.

Build failure: cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'

RESOLVED FIXED in Thunderbird 23.0

Status

MailNews Core
Backend
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Stefan Sitter, Assigned: Ms2ger)

Tracking

Trunk
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
After applying the bustage fix from Bug 864256 I ran into the following problem:

> .../mailnews/base/src/nsMsgFolderDataSource.cpp(186) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(187) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(188) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(189) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(190) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(191) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(192) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(193) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(194) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(195) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(196) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(197) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(198) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgAccountManagerDS.cpp(164) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsStatusBarBiffManager.cpp(58) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgDBView.cpp(152) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgDBView.cpp(153) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'

Probably caused by the check-in for Bug 859817 (Make NS_NewAtom return already_AddRefed).
(Assignee)

Comment 1

4 years ago
Created attachment 742710 [details] [diff] [review]
Patch v1
Attachment #742710 - Flags: review?(mbanner)
Comment on attachment 742710 [details] [diff] [review]
Patch v1

Review of attachment 742710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks.
Attachment #742710 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/comm-central/rev/271b24c7b667
Assignee: nobody → Ms2ger
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Depends on: 859817
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → Thunderbird 23.0
(Assignee)

Comment 4

4 years ago
And one more missed caller:

https://hg.mozilla.org/comm-central/rev/3d3e10b5c289
You need to log in before you can comment on or make changes to this bug.