Closed Bug 866429 Opened 8 years ago Closed 8 years ago

Simplify shutdown cycle collections

Categories

(Core :: XPCOM, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

"MainThreadCollect" is really "ShutdownCollect", and we always pass in the same arguments, so the type can be simplified.  The loop in this method is also weird, so I fixed that up to be more conventional, plus I eliminated a macro definition that isn't meaningful any more.
Attached patch simplify shutdown CCs (obsolete) — Splinter Review
Attachment #742724 - Flags: review?(bugs)
Attachment #742724 - Flags: review?(bugs) → review+
Priority: -- → P2
Rebased.  Carrying forward smaug's r+.
try run: https://tbpl.mozilla.org/?tree=Try&rev=fc33865c6a57
Just waiting for inbound to reopen.
Attachment #742724 - Attachment is obsolete: true
Attachment #751055 - Flags: review+
Depends on: 865320
https://hg.mozilla.org/mozilla-central/rev/5d08f867dc52
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.