Last Comment Bug 866487 - MOZ_UPDATER always set to true in
: MOZ_UPDATER always set to true in
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: ARM Android
-- normal (vote)
: Firefox 23
Assigned To: Chen Dai
: Sebastian Kaspari (:sebastian)
Depends on:
Blocks: 786380
  Show dependency treegraph
Reported: 2013-04-27 22:10 PDT by Chen Dai
Modified: 2013-05-09 10:26 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch for bug866487 (769 bytes, patch)
2013-05-01 06:41 PDT, Chen Dai
snorp: review+
Details | Diff | Splinter Review

Description User image Chen Dai 2013-04-27 22:10:45 PDT
User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.20 (KHTML, like Gecko) Chrome/25.0.1337.0 Safari/537.20

Steps to reproduce:

set MOZ_UPDATER= in mobile/android/branding/unofficial/

Actual results:

MOZ_UPDATER set to true in

Expected results:

MOZ_UPDATER set to false in

it should add ifdef XXX in android/base/ before "-DMOZ_UPDATER=$(MOZ_UPDATER)"
Comment 1 User image Jim Chen [:jchen] [:darchons] 2013-04-29 08:14:33 PDT
Hi Chen, since you already found the cause of the issue, would you like to contribute a patch to fix it?
Comment 2 User image Chen Dai 2013-05-01 06:41:57 PDT
Created attachment 744100 [details] [diff] [review]
patch for bug866487

I made a patch for android
Comment 3 User image Ryan VanderMeulen [:RyanVM] 2013-05-08 21:01:50 PDT
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2013-05-09 10:26:46 PDT

Note You need to log in before you can comment on or make changes to this bug.