866501 - android.content.res.Resources$NotFoundException: Resource is not a ColorStateList (color or path): TypedValue{t=0x2/d=0x1010350 a=<n>}: at android.content.res.Resources.loadColorStateList(Resources.java) mainly on HTC devices running Gingerbread

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 23.0a1/20130427, bp-55d256b6-b46c-454e-b231-b1def2130427, after the fix of bug 861658.

android.content.res.Resources$NotFoundException: Resource is not a ColorStateList (color or path): TypedValue{t=0x2/d=0x1010350 a=3}
	at android.content.res.Resources.loadColorStateList(Resources.java:1822)
	at android.content.res.TypedArray.getColorStateList(TypedArray.java:342)
	at android.widget.TextView.<init>(TextView.java:458)
	at android.widget.TextView.<init>(TextView.java:385)
	at java.lang.reflect.Constructor.constructNative(Native Method)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:415)
	at android.view.LayoutInflater.createView(LayoutInflater.java:505)
	at com.android.internal.policy.impl.PhoneLayoutInflater.onCreateView(PhoneLayoutInflater.java:56)
	at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:568)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:623)
	at android.view.LayoutInflater.rInflate(LayoutInflater.java:626)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:408)
	at android.view.LayoutInflater.inflate(LayoutInflater.java:320)
	at com.android.internal.view.menu.MenuItemImpl.createItemView(MenuItemImpl.java:609)
	at com.android.internal.view.menu.MenuItemImpl.getItemView(MenuItemImpl.java:594)
	at com.android.internal.view.menu.MenuBuilder$MenuAdapter.getView(MenuBuilder.java:1188)
	at android.widget.AbsListView.obtainView(AbsListView.java:1430)
	at android.widget.ListView.measureHeightOfChildren(ListView.java:1264)
	at android.widget.ListView.onMeasure(ListView.java:1127)
	at android.view.View.measure(View.java:8526)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3224)
	at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1017)
	at android.widget.LinearLayout.measureVertical(LinearLayout.java:386)
	at android.widget.LinearLayout.onMeasure(LinearLayout.java:309)
	at android.view.View.measure(View.java:8526)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3224)
	at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1017)
	at android.widget.LinearLayout.measureVertical(LinearLayout.java:386)
	at android.widget.LinearLayout.onMeasure(LinearLayout.java:309)
	at com.android.internal.widget.WeightedLinearLayout.onMeasure(WeightedLinearLayout.java:60)
	at android.view.View.measure(View.java:8526)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3224)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:250)
	at android.view.View.measure(View.java:8526)
	at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:3224)
	at android.widget.FrameLayout.onMeasure(FrameLayout.java:250)
	at android.view.View.measure(View.java:8526)
	at android.view.ViewRoot.performTraversals(ViewRoot.java:902)
	at android.view.ViewRoot.handleMessage(ViewRoot.java:1957)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:150)
	at android.app.ActivityThread.main(ActivityThread.java:4263)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/query/query?product=FennecAndroid&query_search=signature&query_type=contains&query=android.content.res.Resources.loadColorStateList&do_query=1

Comment 1

[Scoobidiver (away)]

There are two crashes from another user in today's build so the regression range might be:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a6104e0e5a2c&tochange=0e45f1b9521f
It might be a regression from bug 863379.

Comment 2

[Scoobidiver (away)]

Comments talk about long tapping in the address bar or in one of the top sites.

Comment 3

[Aaron Train [:aaronmt]]

> Comments talk about long tapping in the address bar or in one of the top
> sites.

Comment #0's https://crash-stats.mozilla.com/report/index/55d256b6-b46c-454e-b231-b1def2130427

HTC Supersonic (EVO 4G). Kevin can you try the EVO 4G?

Comment 4

[Scoobidiver (away)]

It's #6 top crasher in 23.0a1.

Comment 5

[Lucas Rocha (:lucasr)]

Steps to reproduce?

Comment 6

[Scoobidiver (away)]

(In reply to Lucas Rocha (:lucasr) from comment #5)
> Steps to reproduce?
See comment 2.

Comment 7

[Aaron Train [:aaronmt]]

No luck reproducing on my HTC Nexus One (Android 2.3); I don't have any 2.3 HTC devices with SenseUI if that makes any difference.

Comment 8

[Teodora Vermesan (:TeoVermesan)]

I am able to reproduce this on HTC Desire Z(Android 2.3.3) on Firefox for Android 23.0a1 (2013-05-07)

Comment 9

[Scoobidiver (away)]

Teodora, what are exactly your steps to reproduce?

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open Firefox
2. Long tap on the awesomebar

Comment 11

[Aaron Train [:aaronmt]]

Needs an assignee now that there are steps.

Comment 12

[Sriram Ramasubramanian [:sriram]]

I have a HTC desire running Froyo and I couldn't reproduce this issue.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #12)
> I have a HTC desire running Froyo and I couldn't reproduce this issue.

Check to see if Kevin or Erin have a HTC Desire Z or HD you can try.

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

I dropped off a HTC Evo 3d that can repro.

Comment 15

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The themes.xml had references to "textColorLinkInverse", which is available only in 11+. This caused the crashes. Ideally we should use a color resource directly here. However, we don't use the textColorLink anywhere, and we can safely re-use it here for the sake of completeness. This patch works fine without crashing.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 748932 [details] [diff] [review]
Patch

Will it be bad to change textColorLinkInverse to textColorLink in Xxx.Inverse styles?

r+ but look into my question

Comment 17

[Sriram Ramasubramanian [:sriram]]

(In reply to Mark Finkle (:mfinkle) from comment #16)
> Comment on attachment 748932 [details] [diff] [review]
> Patch
> 
> Will it be bad to change textColorLinkInverse to textColorLink in
> Xxx.Inverse styles?
> 
> r+ but look into my question

That color is not used anywhere. It's for the sake of completion I added it. So we won't run into any problem with that.

Comment 18

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4bd174a6a18

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4bd174a6a18

Comment 20

[Adrian Tamas (:AdrianT)]

This is also reproducible when trying to use the Lightweight Theme Switcher addon on the HTC Desire Z (Android 2.3.3) on Aurora 23.0a2 2013-05-15

Comment 21

[Scoobidiver (away)]

When is the patch uplifted to Aurora?

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - This needs an uplift. Please request one.

Comment 23

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 748932 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New styles.
User impact if declined: HTC phones running 2.3 will crash.
Testing completed (on m-c, etc.): m-c on 05/15
Risk to taking this patch (and alternatives if risky): None. We don't use the "textColorLink". Just that HTC phones want to know the value even when not using it!
String or IDL/UUID changes made by this patch: None.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e1e21759a902

Comment 25

[Nick Alexander :nalexander [he/him] (PTO August 1-10)]

For the record, I saw this (not in Fennec, but in ABS code) running on a Samsung GT-S5570, Android version 2.3.6.