Closed Bug 866535 Opened 10 years ago Closed 7 years ago
Changes in test finder breaks `__$cover
(Add-on SDK Graveyard :: General, defect, P3)
(Reporter: glind, Unassigned)
In or around 879a04f0 ( https://github.com/mozilla/addon-sdk/commits/879a04f0 ), something changed with test discovery that makes it that the `global` var at https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/test/harness.js#L583 no longer runs. FWICT, in this layout: sdk/test/harness <- uses CustomLoader, YES `global` --> test-main.js <- found by deprecated/unit-test-finder, no `global` - require("./main.js") <- no global TO FIX: - the harness CustomLoader needs to be used at https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/deprecated/unit-test-finder.js#L58 as well. If you want to see how this impacts an addon... see https://github.com/gregglind/lotsa_addons/tree/master/covertest (Also, of people want to revisit how to do code coverage, I am open to suggestions!)
Priority: -- → P3
10 years ago
8 years ago
Is this still an issue?
7 years ago
We still sort of have test coverage working. It's super flaky and fragile and uses `freaktechnik/istanbul-jpm`
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.