Closed Bug 866569 Opened 10 years ago Closed 10 years ago

Unlink nsXULPrototypeNodes more completely

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file, 1 obsolete file)

nsXULPrototypeElement::Unlink() doesn't clear the node info or children, for no reason I can see.  I've had this in my stack of ICC patches for a while, and it seems okay.  Breaking down things like this probably helps with incrementalization.
Attached patch unlink more completely (obsolete) — Splinter Review
Assignee: nobody → continuation
Summary: Unlink nsXULPrototypeNodes more aggressively → Unlink nsXULPrototypeNodes more completely
Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Does this look okay to you?  I have a vague worry that the nsXULDocument or whatever will try to look at its nodes after it is unlinked but before it is destroyed.  Nothing shows up on try, but try doesn't always find XUL regressions. ;)
Attachment #742904 - Flags: feedback?(bugs)
Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Unlinking mNodeInfo is somewhat surprising (nodeinfo tends to be a thing which is alive until dtor), but unlinking children sounds ok.
Attachment #742904 - Flags: feedback?(bugs) → feedback+
Attachment #786344 - Flags: review?(bugs)
Attachment #786344 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ef8348f88821
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.