866569 - Unlink nsXULPrototypeNodes more completely

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Andrew McCreight [:mccr8]]

nsXULPrototypeElement::Unlink() doesn't clear the node info or children, for no reason I can see.  I've had this in my stack of ICC patches for a while, and it seems okay.  Breaking down things like this probably helps with incrementalization.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: unlink more completely

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Does this look okay to you?  I have a vague worry that the nsXULDocument or whatever will try to look at its nodes after it is unlinked but before it is destroyed.  Nothing shows up on try, but try doesn't always find XUL regressions. ;)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Unlinking mNodeInfo is somewhat surprising (nodeinfo tends to be a thing which is alive until dtor), but unlinking children sounds ok.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: unlink children

https://tbpl.mozilla.org/?tree=Try&rev=19ba8ef14f55

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef8348f88821

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef8348f88821