Unlink nsXULPrototypeNodes more completely

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
nsXULPrototypeElement::Unlink() doesn't clear the node info or children, for no reason I can see.  I've had this in my stack of ICC patches for a while, and it seems okay.  Breaking down things like this probably helps with incrementalization.
(Assignee)

Comment 1

6 years ago
Created attachment 742904 [details] [diff] [review]
unlink more completely
Assignee: nobody → continuation
(Assignee)

Updated

6 years ago
Summary: Unlink nsXULPrototypeNodes more aggressively → Unlink nsXULPrototypeNodes more completely
(Assignee)

Comment 2

6 years ago
Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Does this look okay to you?  I have a vague worry that the nsXULDocument or whatever will try to look at its nodes after it is unlinked but before it is destroyed.  Nothing shows up on try, but try doesn't always find XUL regressions. ;)
Attachment #742904 - Flags: feedback?(bugs)

Comment 3

6 years ago
Comment on attachment 742904 [details] [diff] [review]
unlink more completely

Unlinking mNodeInfo is somewhat surprising (nodeinfo tends to be a thing which is alive until dtor), but unlinking children sounds ok.
Attachment #742904 - Flags: feedback?(bugs) → feedback+
(Assignee)

Updated

5 years ago
Attachment #786344 - Flags: review?(bugs)

Updated

5 years ago
Attachment #786344 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ef8348f88821
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.