866615 - [Bluetooth] Reset is occurred when received video file via bluetooth OPP

Status: VERIFIED FIXED

Description

[leo.bugzilla.gecko]

Dear Mozilla Team,

In our latest version, reset is occured when received video file via bluetooth OPP.
So, I have reviewed for latest patches, and I found a mismatch code.

====================================================
- BluetoothOppManager.cpp
mDsFile = new DeviceStorageFile(NS_LITERAL_STRING("movies"), storagePath);

- nsDeviceStorage.cpp
#define DEVICESTORAGE_VIDEOS     "videos"

// Video directory
else if (aType.EqualsLiteral(DEVICESTORAGE_VIDEOS)) {
====================================================

GetRootDirectoryForType function was added In nsDeviceStorage.cpp, 
and then bt side send string "movies" to DeviceStorageFile but DeviceStorage side define this string to "videos".
Eventually DeviceStorage is not matched the type, so reset is occurred during file writing.

This code is same as Mozilla-Central, maybe your device will be reproduced.
So, I modified the literal string from "movies" to "videos" and reset is not occurred.

Please check this code.

Thanks.

Comment 1

[Eric Chou [:ericchou] [:echou]]

When I implemented this part of code, I thought the DeviceStorage media types were "pictures", "movies" and "music". However, "movies" should be replaced with "videos".

Comment 2

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: modify nsDeviceStorageFile from 'movies' to 'videos'

Comment 3

[Daniel Coloma:dcoloma]

Blocking, assuming this also occurs in 1.0.1

Comment 4

[Eric Chou [:ericchou] [:echou]]

birch: https://hg.mozilla.org/projects/birch/rev/3968311ac65b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3968311ac65b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/4451d7bc0912
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/5c1d67e0c242

Comment 8

[Sarah Parsons]

Verified fixed on Inari Build ID: 20130503070205
Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f

Also verified fixed on Unagi Unagi Build ID: 20130503070205
Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f

Videos can be successfully sent and received via bluetooth without reset.