866662 - Group url not always unique.

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Giorgos Logiotatidis [:giorgos]]

The auto-generated group url is not always guarantied to be unique. Steps to reproduce:

1. Create a group e.g. 'la lo' (this should have url 'la-lo')
2. Merge this group into another group, e.g. 'staff'
3. Create another group with name which generates same url 'la-lo'
4. New group has same url with first group.

This is only reproducable when you merge the first group into another group, because the url generation algorithm doesn't look into the aliases table for conflicting urls.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/6d634ad4b12d78fdf32538d1da8079c7189f3e19
[fix bug 866662] Calculate group unique url based on aliases.

Comment 2

[Matt Brandt [:mbrandt]]

QA verified on stage - nicely done.

Groups that match the pattern noted in comment 0 are correctly resovled.

For instance:
1. if group 'bambi-deer' is created 
2. and then 'bambi deer' is created

'bambi deer' becomes 'bambi-deer2'