866690 - [Dialer] Call Log broken due to mcc being null if no SIM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

If we start the device with no SIM, the Call Log does start correctly since mozMobileConnection.voice.network.mcc is null and the toString() function is invoked on it -> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/recents.js#L168

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Sorry, I meant "the Call Log does NOT start correctly" :-)

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

I have just confirmed that this bug also happens in v1.0.1 due the same problem ;-)

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 743062 [details]
Associated PR.

Good catch!

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Merged! Thanks to Etienne for the review ;-)

Commit in master: https://github.com/mozilla-b2g/gaia/commit/8278a62077e7561813b0ff041ce2e5c846eecb70

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 8278a62077e7561813b0ff041ce2e5c846eecb70 to:
v1-train: e420d71c9528786621f176fb4ce67d291e0a530e

Commit 8278a62077e7561813b0ff041ce2e5c846eecb70 didn't uplift to branch v1.0.1

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi all,

This patch needs to be uplifted to v1.0.1 to address the issue described in Bug 865469.
Please let me know if you need me to help on the uplift.
Thank you.

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Uplifted to v1.0.1: https://github.com/mozilla-b2g/gaia/commit/06992cf4ed4ff640c85605332add804cf12aad28

Comment 10

[Jeni]

Verfied fixed on 

Inari Build ID: 20130506070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ce67220b877d
Gaia: 1e598d8842920d9e0b1743dc6fe9390bd5f6e2df


and on 

Unagi Build ID: 20130506070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/00c554abfc17
Gaia: 9377636cee5ac55b9f1d68f598afc7aadfbb2b00

User can now see call log with or without sim card inserted into device.