866702 - Decouple DEBUG=1 from Firefox desktop compatibility helpers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alexandre Poirot [:ochameau]]

We recently introduced a bunch of new behavior when settting DEBUG=1,
but it ends up being misleading as you don't necessarily want desktop support in debug mode, and you also may want desktop support without being in full debug mode. For example, you may want app:// protocol in the browser.

We should then introduce a new specific environment variable to only toggle browser support.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 9458

I also fixed the desktop helper to allow closing it.
And stopped forcing displaying Firefox OS panel,
so that if you restart firefox, it will display the last opened panel.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 743078 [details]
Pull request 9458

r+ with github/s comments fixed.

Comment 3

[Kevin Grandon :kgrandon]

Alexandre - I think the use case for wanting a DEBUG profile without desktop support is extremely rare. This will also break lots of tutorials/documentation on the web (not too hard to update, but something we need to do).

I would like to request that we set the new DESKTOP variable to be true for DEBUG profiles if it's not specified. I strongly believe that most folks want full desktop support by default.

Comment 4

[Alexandre Poirot [:ochameau]]

I'm not convinced that's the best future-wise option, but I'm not fondamentaly against it, so I pushed an amended commit with vivien comments being addressed,
and did that: BROWSER?=$(DEBUG)
to address your concern.

Are you also requesting to name this variable DESKTOP instead of BROWSER?

It would be super handy if you can give a try to this branch with various env variable combination.

Comment 5

[Alexandre Poirot [:ochameau]]

Landed in:
master: https://github.com/mozilla-b2g/gaia/commit/0e20a5edd5a8a0ce504f7cdfc6a7b47bb218ac38

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 743078 [details]
Pull request 9458

Requesting uplift as we would like to have all of the developer tools/productivity related things uplifted. It also has zero impact to gaia builds as all changes are external to application code.

Comment 7

[Alexandre Poirot [:ochameau]]

Uplifted:
v1-train: 9377636cee5ac55b9f1d68f598afc7aadfbb2b00

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Alexandre Poirot (:ochameau) from comment #7)
> Uplifted:
> v1-train: 9377636cee5ac55b9f1d68f598afc7aadfbb2b00

Hey, thanks for uplifting.  Please mark the status-b2g18* flags when you resolve on branch.