866732 - [socorro-crashstats] TypeError on use of urlencode in report index

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

See https://errormill.mozilla.org/webtools/socorro-crashstats-stage/group/15421/

Steps to reproduce:

1. http://crash-stats-django.allizom.org/report/index/03639a93-c299-45d6-8a61-570f72130421
2. Fails to load

Comment 1

[Peter Bengtsson [:peterbe]]

This happens because the data we get back from /crash_data/ on stage contains a structure whose value of `os_name` or `signature` is None. 

Both are needed in the template and don't allow for not being set.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

TypeError: argument of type 'NoneType' is not iterable

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/views.py", line 180, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 896, in report_index
    return render(request, 'crashstats/report_index.html', data)
  File "django/shortcuts/__init__.py", line 44, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),
  File "django/template/loader.py", line 176, in render_to_string
    return t.render(context_instance)
  File "jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/www/crash-stats-django.allizom.org/app/crashstats/crashstats/templates/crashstats/report_index.html", line 1, in top-level template code
    {% extends "crashstats_base.html" %}
  File "/data/www/crash-stats-django.allizom.org/app/crashstats/base/templates/crashstats_base.html", line 132, in top-level template code
    {% block content %}{% endblock %}
  File "/data/www/crash-stats-django.allizom.org/app/crashstats/crashstats/templates/crashstats/report_index.html", line 488, in block "content"
    path: '/{{ product }}/{{ version }}/{{ report.os_name | urlencode }}/{{ report.signature|urlencode }}/',
  File "crashstats/crashstats/helpers.py", line 27, in urlencode
    return urllib.quote_plus(txt)
  File "python2.6/urllib.py", line 1241, in quote_plus
    if ' ' in s:

Comment 3

[Peter Bengtsson [:peterbe]]

This was rewritten a long time ago.