866801 - Provider error: org.mozilla.searches: Failed to initialize: 'Error: Internal error: invalid state FINISHED_SUCCESS' when calling method: [nsIBrowserSearchService::getDefaultEngines]

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

We're seeing this error in < 0.05% of payloads:

Provider error: org.mozilla.searches: Failed to initialize: 'Error: Internal error: invalid state FINISHED_SUCCESS' when calling method: [nsIBrowserSearchService::getDefaultEngines]
Stack trace: resource://gre/modules/HealthReport.jsm:6311
< resource://gre/modules/HealthReport.jsm:6328
< resource://gre/modules/HealthReport.jsm:6347
< resource://gre/modules/HealthReport.jsm:963
< SearchCountMeasurement2()@resource://gre/modules/HealthReport.jsm:6298
< init()@resource://gre/modules/HealthReport.jsm:1448
< TaskImpl_run()@resource://gre/modules/Task.jsm:192
< effort()@resource://gre/modules/commonjs/sdk/core/promise.js:55
< resolved()@resource://gre/modules/commonjs/sdk/core/promise.js:117
< then()@resource://gre/modules/commonjs/sdk/core/promise.js:37
< resolve()@resource://gre/modules/commonjs/sdk/core/promise.js:143
< <file:unknown>

It quacks like a search service internal error.

FWIW, I'm only seeing 2 errors on Nightly, and both were from the 20130405030918 build (possibly the same client?) and 20 on Aurora (from many builds).

Gavin: any ideas? Feel free to reassign to an appropriate component if this isn't FHR's fault.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

That suggests that something's going wrong with the async/sync search service initialization code that Yoric wrote, but I don't know what offhand (wish we had a more complete stack trace).

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Looks like something is attempting to initialize the search service although it is already initialized. Looking at the source code, I can't see how this can happen.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I suspect this is the same cause as bug 866254.
I have just uploaded a prototype patch.

Comment 4

[Georg Fritzsche [:gfritzsche]]

FHR is going away per bug 1209088, closing.