866815 - Integrate login.webmaker.org into thimble

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

The webmaker.org repo has a README that can act as an example on how to do this integration.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Pomax: planning on getting to this tomorrow/Friday?

Comment 2

[Pomax]

very much so, apparently this ticket was missing dependencies.

Comment 3

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/49

Comment 4

[Pomax]

This does still miss a section in the README on how to make sure all the cookie settings match up with login.wm, so I'll add that in, too.

Comment 5

[Pomax]

readme added.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

Comments in the pull request.

For the most part I got this setup alright.

It seems to be failing when I try to publish, likely due to the comment in the pull request.

Comment 7

[Ross Bruniges [:boozeniges]]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

Got a few things that I would like to see come together before looking at this again. Comments in github

Comment 8

[Pomax]

note: unhappy with the use of both parser_secret and session_secret, filed https://github.com/visionmedia/express/issues/1607 to find out what the correct way of doing things is here, since the docs are not sufficient to determine that.

Comment 9

[Pomax]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

added ross back in, since his issues got address and he wanted another pass after that happened.

Comment 10

[Ross Bruniges [:boozeniges]]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

Rocking.

Thanks for the fixes!

Comment 11

[David Humphrey (:humph)]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

Initial code review, comments in the ticket.  I'll ask for functional review from some of the others already listed here.

Comment 12

[Pomax]

fixed dave's points (except for a stylistic one). I'd like a function review by jbuck.

Comment 13

[Jon Buckley]

Not sure if it's a problem, but I'm getting an error message when I visit the page while logged out: 

[17:29:08.549] Error in handler. @ sso.js:149
[17:29:08.549] publishButton.hide is not a function @ sso.js:150

Comment 14

[Jon Buckley]

Comment on attachment 746022 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/49

I also cannot seem to get this working on heroku. I get a lovely:

"Sorry, an error occurred while trying to publish. Error: please log in first at checkForPersonaAuth (/app/lib/middleware.js:12:21)"

There's also some things to fix up in the PR.

Comment 15

[Pomax]

that's odd, the code for the publishbutton is supposed to kick in after friendlycode loads up. I'll have a look at why you're getting that middleware error - it would suggest your cookie is in fact not set correctly. Did you remember to set both login and thimble to the .herokuapps.com cookie domain?

Comment 16

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/54

new pull request with updated SSO instead

Comment 17

[Jon Buckley]

Comment on attachment 748009 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/54

r+

Comment 18

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/bb946e9df06d9e85dc45141070bd9883f81e204a
Merge pull request #54 from Pomax/bug866815

updated SSO

Comment 19

[Pomax]

landed.