866845 - Create "Developer" widget

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to open up the devtools toolbox.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Add Developer button widget to toolbar/ customize panel

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Add Developer button widget to toolbar/ customize panel

fixed a whoopsie

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 745202 [details] [diff] [review]
Add Developer button widget to toolbar/ customize panel

Review of attachment 745202 [details] [diff] [review]:
-----------------------------------------------------------------

Just curious about the keyboard shortcut...

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +235,5 @@
>      }
> +  }, {
> +    id: "developer-button",
> +    name: "Developer",
> +    shortcut: "Shift+F11",

Where is this keyboard shortcut coming from?

@@ +236,5 @@
> +  }, {
> +    id: "developer-button",
> +    name: "Developer",
> +    shortcut: "Shift+F11",
> +    description: "Toggle Developer Tools",

I was about to hassle you about casing here, but I guess "Developer Tools" is a name, isn't it.

We'll want to review all of these strings anyways when we make this all l10n friendly.

@@ +245,5 @@
> +      "32": "chrome://branding/content/icon48.png",
> +      "48": "chrome://branding/content/icon48.png"
> +    },
> +    onCommand: function(aEvent) {
> +      let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;

3 line break-up please.

@@ +329,5 @@
>      "find-button",
>      "history-panelmenu",
>      "bookmarks-panelmenu",
> +    "open-file-button",
> +    "developer-button"

We shouldn't be adding this to the default set.

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Add Developer button widget to toolbar/ customize panel

addressed comments, carrying over r+=mconley

Comment 5

[Mike de Boer [:mikedeboer]]

erm, that last part of the comment was a copy-paste booboo: no r+ yet ;)

Comment 6

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 745386 [details] [diff] [review]
Add Developer button widget to toolbar/ customize panel

Review of attachment 745386 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +241,5 @@
>      }
> +  }, {
> +    id: "developer-button",
> +    name: "Developer",
> +    shortcut: "Shift+F11",

Still curious about why you chose this shortcut combination. Where did you get this from?

Comment 7

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 745386 [details] [diff] [review]
Add Developer button widget to toolbar/ customize panel

Review of attachment 745386 [details] [diff] [review]:
-----------------------------------------------------------------

mikedeboer and I talked about this in IRC. We'll revisit the shortcut keys when we look at making the strings localized.

Comment 8

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

https://hg.mozilla.org/projects/jamun/rev/db3e662b2c2d

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/db3e662b2c2d