866984 - Bookmark icon not obvious when an alternative blue Firefox theme is set

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: screenshot

Switch to the Sky Blue theme:

https://addons.mozilla.org/en-US/firefox/addon/sky-blue-cheetah-print/

Now the bookmarks' icon which landed in bug 748894 is no longer obvious, whether the page is bookmarked or not.

See screenshot.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

looks like a problem for any button with this theme, the back button is barely visible...

Comment 2

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [:mak] from comment #1)
> looks like a problem for any button with this theme, the back button is
> barely visible...

Yes, we need inverted icons on OSX like we have on Windows.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The problem appears also on Windows, this theme is not enforcing the inverted icons.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Marco Bonardo [:mak] from comment #3)
> The problem appears also on Windows, this theme is not enforcing the
> inverted icons.

So is this a Firefox issue, or a theme issue?

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think this depends on the text color that is associated with the theme, this theme is basically blue/black, but uses black for text, indeed text is already unreadable.
Afaik we base the choice of inverted icons based on that color, though I'm not up-to-date with the current code (I think there is some color calculation on AMO).
Doesn't look like a Firefox bug.

Comment 6

[Justin Dolske [:Dolske]]

Agreed. Not much to do here, use a less-busy theme.