867039 - [Lock Screen][User Story] Password unlock in a single step

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Peter Dolanjski [:pdol]]

UCID: Lock-017

User Story:
As a user who uses a password on my phone, I would like to be able to unlock the screen in one step by entering the password instead of unlocking the screen and then needing to enter the password in order to save time during the unlock process.

Comment 1

[Kevin Grandon :kgrandon]

Spoke with Michael about this. I actually already have a simple patch, and will take this one. Sorry about the confusion!

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 749413 [details]
Github pull request pointer

Alive - maybe you could review this one?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 749413 [details]
Github pull request pointer

Ya I could but I rather transfer the review to Yuren because he is taking care of Lockscreen now.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

applied patch and looks cool! reviewing...

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

code looks good. but before I give r+, I would like to heart UX opinion for this change. Josh, could you give some feedback for this?

Comment 7

[Kevin Grandon :kgrandon]

We are also waiting on design feedback from Patryk in bug #867219.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

forgot video url LOL

https://docs.google.com/a/mozilla.com/file/d/0B-FHjXny08MtSTBMeDZmb0JPWGs/edit

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 749413 [details]
Github pull request pointer

Hi Yuren - we've received UX feedback+ from Patryk in bug 867219. Adding you as reviewer again, we can also leave Josh as feedback? in case he has anything else.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 749413 [details]
Github pull request pointer

here we go~

Comment 11

[Kevin Grandon :kgrandon]

Code has landed in master: https://github.com/mozilla-b2g/gaia/commit/83643d05ee93a0f0bb4b3d3239384736514a92d4

Comment 12

[Mike Lee [:mlee]]

Kevin, please request approval-gaia-v1? for this. We need to get this uplifted to 1.1.

Comment 13

[Kevin Grandon :kgrandon]

As this bug is leo+, it should be auto-uplifted to 1.1 if my understanding is correct.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Kevin Grandon :kgrandon from comment #13)
> As this bug is leo+, it should be auto-uplifted to 1.1 if my understanding
> is correct.

Right, that's correct.

Comment 15

[Gareth Aye [:gaye] (back from PTO)]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 83643d05ee93a0f0bb4b3d3239384736514a92d4
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 16

[Kevin Grandon :kgrandon]

Landed in v1-train: https://github.com/mozilla-b2g/gaia/commit/e3be614981c71f8e9c8860c3f81edab4c0ee3619

Comment 17

[Al Tsai [:atsai]]

test case is created.
https://moztrap.mozilla.org/manage/case/8214/

Comment 18

[Al Tsai [:atsai]]

Looks good to me on the PVT build.