Closed Bug 867039 Opened 7 years ago Closed 7 years ago

[Lock Screen][User Story] Password unlock in a single step

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18+ fixed)

VERIFIED FIXED
1.1 QE2 (6jun)
blocking-b2g leo+
Tracking Status
b2g18 + fixed

People

(Reporter: pdol, Assigned: kgrandon)

References

Details

(Keywords: feature, Whiteboard: c=)

Attachments

(1 file)

UCID: Lock-017

User Story:
As a user who uses a password on my phone, I would like to be able to unlock the screen in one step by entering the password instead of unlocking the screen and then needing to enter the password in order to save time during the unlock process.
Summary: [User Story][Lock Screen] Password unlock in a single step → [Lock Screen][User Story] Password unlock in a single step
Depends on: 867219
tracking-b2g18: --- → +
Whiteboard: c=
Assignee: nobody → mhenretty
Status: NEW → ASSIGNED
Keywords: feature
Spoke with Michael about this. I actually already have a simple patch, and will take this one. Sorry about the confusion!
Assignee: mhenretty → kgrandon
Comment on attachment 749413 [details]
Github pull request pointer

Alive - maybe you could review this one?
Attachment #749413 - Flags: review?(alive)
Comment on attachment 749413 [details]
Github pull request pointer

Ya I could but I rather transfer the review to Yuren because he is taking care of Lockscreen now.
Attachment #749413 - Flags: review?(alive) → review?(yurenju.mozilla)
applied patch and looks cool! reviewing...
code looks good. but before I give r+, I would like to heart UX opinion for this change. Josh, could you give some feedback for this?
Flags: needinfo?(jcarpenter)
Attachment #749413 - Flags: review?(yurenju.mozilla)
We are also waiting on design feedback from Patryk in bug #867219.
Comment on attachment 749413 [details]
Github pull request pointer

Hi Yuren - we've received UX feedback+ from Patryk in bug 867219. Adding you as reviewer again, we can also leave Josh as feedback? in case he has anything else.
Attachment #749413 - Flags: review?(yurenju.mozilla)
Comment on attachment 749413 [details]
Github pull request pointer

here we go~
Attachment #749413 - Flags: review?(yurenju.mozilla) → review+
Code has landed in master: https://github.com/mozilla-b2g/gaia/commit/83643d05ee93a0f0bb4b3d3239384736514a92d4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
blocking-b2g: --- → leo+
Kevin, please request approval-gaia-v1? for this. We need to get this uplifted to 1.1.
Flags: in-moztrap?
As this bug is leo+, it should be auto-uplifted to 1.1 if my understanding is correct.
(In reply to Kevin Grandon :kgrandon from comment #13)
> As this bug is leo+, it should be auto-uplifted to 1.1 if my understanding
> is correct.

Right, that's correct.
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 83643d05ee93a0f0bb4b3d3239384736514a92d4
  <RESOLVE MERGE CONFLICTS>
  git commit
QA Contact: atsai
Hardware: x86 → ARM
Flags: in-moztrap? → in-moztrap+
Flags: in-moztrap+ → in-moztrap-
Looks good to me on the PVT build.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jcarpenter)
Target Milestone: --- → 1.1 QE2 (6jun)
You need to log in before you can comment on or make changes to this bug.