Closed
Bug 867055
Opened 12 years ago
Closed 12 years ago
'this' is undefined in getArgs
Categories
(L20n :: JS Library, defect, P1)
L20n
JS Library
Tracking
(Not tracked)
RESOLVED
FIXED
1.0 beta
People
(Reporter: stas, Assigned: stas)
Details
Attachments
(1 file, 1 obsolete file)
|
2.23 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
When I landed https://github.com/l20n/l20n.js/commit/1f8ec4a2eb339ed513ab4673aff94648b22dcfd0 I only tested with some data passed to the get(), and the error was silent.
I'll have a patch in a second.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #743486 -
Flags: review?(gandalf)
|
|
Assignee | |
Comment 2•12 years ago
|
||
D'oh, I missed two other places.
Attachment #743486 -
Attachment is obsolete: true
Attachment #743486 -
Flags: review?(gandalf)
Attachment #744070 -
Flags: review?(gandalf)
|
||
Updated•12 years ago
|
Attachment #744070 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
This was fixed by a pull request by matthiasmullie: https://github.com/l20n/l20n.js/commit/712302f0fe12b5aec7f91c1d2fd9f27de877e4d0 and https://github.com/l20n/l20n.js/commit/0920b2756378039722fe94f12102ba9b5527e69a. Thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•