Closed Bug 867059 Opened 8 years ago Closed 8 years ago

"Set as Default" option still available in context menu after disabling a search engine

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
23 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec+)

Status:
VERIFIED FIXED
Milestone:
Firefox 23
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: u421692, Assigned: Margaret)

References

Details

(Keywords: reproducible)

Attachments

(2 files)

Screenshot
50.22 KB, image/png
Details
patch
1.79 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
Attached image Screenshot — 
Environment:
Build: Firefox for Android 23.0a1 (2013-04-29)
Device: Samsung Galaxy Tab 10.1(GT-P7510)
OS: Android 4.0.4

Steps to reproduce:
1. Go to Add-ons screen.
2. Disable a search engine that is not default.
3. Long tap on the disabled search engine to open context menu.
4. Check the context menu.

Expected result:
Context menu should display only "Enable" option.

Actual result:
Context menu displays "Enable" and "Set as Default" option.
"Set as Default" option should not be present when search engine is disabled.
Depends on: 730445
This is also the case for the following scenario: 
1. Go to Add-ons screen.
2. Set as Default a search engine.
3. Long tap on the same search engine to open context menu.
4. Check the context menu.

Expected result:
Context menu should display only "Disable" option.

Actual result:
Context menu displays "Enable" and "Set as Default" option.
"Set as Default" option should not be present when search engine is already default.
Keywords: reproducible
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → ?
Attached patch patch — — Splinter Review
Attachment #743735 - Flags: review?(mark.finkle)
Attachment #743735 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → +
https://hg.mozilla.org/mozilla-central/rev/ebad4b72a6ea
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.