867096 - Convert nsTransactionStack from nsDeque to std::deque

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

This incidentally helps fix bug 859817 by removing some implicit conversions to already_AddRefed.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Disadvantage of std::deque: undefined behavior.  Stuff like the return type of .size() is not defined by the standard.  Sigh.  Try run is pending, so I don't know for sure yet that this even compiles on other platforms.

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Interdiff for fixed patch

Dur, I got the deque backwards and broke item().  Yay for tests!  Try run with new patch to show it works (orange/red is from other patches in the series):

https://tbpl.mozilla.org/?tree=Try&rev=9db698a8c4bb

Comment 3

[(no longer active)]

Comment on attachment 746337 [details] [diff] [review]
Interdiff for fixed patch

Review of attachment 746337 [details] [diff] [review]:
-----------------------------------------------------------------

Hah! Sorry, I should have caught this.  Please fold the two patches together before landing.

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5971dba36391

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5971dba36391