Closed
Bug 867096
Opened 12 years ago
Closed 12 years ago
Convert nsTransactionStack from nsDeque to std::deque
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(2 files)
|
5.05 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
1.20 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This incidentally helps fix bug 859817 by removing some implicit conversions to already_AddRefed.
Flags: in-testsuite-
|
Assignee | |
Comment 1•12 years ago
|
||
Disadvantage of std::deque: undefined behavior. Stuff like the return type of .size() is not defined by the standard. Sigh. Try run is pending, so I don't know for sure yet that this even compiles on other platforms.
Attachment #743553 -
Flags: review?(ehsan)
|
||
Updated•12 years ago
|
Attachment #743553 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Dur, I got the deque backwards and broke item(). Yay for tests! Try run with new patch to show it works (orange/red is from other patches in the series):
https://tbpl.mozilla.org/?tree=Try&rev=9db698a8c4bb
Attachment #746337 -
Flags: review?(ehsan)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 746337 [details] [diff] [review]
Interdiff for fixed patch
Review of attachment 746337 [details] [diff] [review]:
-----------------------------------------------------------------
Hah! Sorry, I should have caught this. Please fold the two patches together before landing.
Attachment #746337 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•