Closed
Bug 867134
Opened 12 years ago
Closed 8 years ago
remove openDialog from window/utils
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: evold, Unassigned)
References
Details
We shouldn't use openDialog ever, and the open method in the same module (sdk/window/utils.js) covers all the possible use cases for openDialog and the ability to open a window without a parent so that windows can be opened even if there are no browser windows currently open.
|
Reporter | |
Comment 1•12 years ago
|
||
Also there doesn't appear to be any explicit test for openDialog, I'm sure it's tested implicitly someplace though. I was going to make this bug about testing openDialog, but removing it seems best to me.
Priority: -- → P3
|
||
Comment 2•12 years ago
|
||
Hi,
I would like to work on this bug.
After reading the above comments, it seems that this bug is just about removing |openDialog| function from window/utils.js. And it's dependencies in bug 843799
Is there need of any kind of test with these changes?
|
||
Comment 3•8 years ago
|
||
Because of the difficulty finding mentors and the expected life span of the SDK, we are removing [good first bug] from remaining SDK bugs.
|
|
||
Updated•8 years ago
|
Whiteboard: [good first bug]
|
||
Comment 4•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•