867148 - parameterize repo in partner repack scripts

Status: VERIFIED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Carsten Book [:Tomcat]]

seems when generating partner repacks out of the beta5 candidates it expects something like hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_21_0b5_RELEASE/browser/installer/windows/app.tag

since we are generating now for beta 5 Partner Repacks in general during the beta release we might have to take care of this, otherwise the partner repacks are not signed and the script exists with an error

2013-04-30 01:45:01,457 - Done repacking mac build Firefox 21.0b5.dmg
2013-04-30 01:45:01,492 - Downloading from http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/21.0b5-candidates/build1/win32/en-US/Firefox%20Setup%2021.0b5.exe
2013-04-30 01:45:01,492 - To: Firefox Setup 21.0b5.exe
2013-04-30 01:45:01,492 - CWD: /Users/tomcat/partner-repacks/scripts/original_builds/21.0b5/build1/win32/en-US
2013-04-30 01:45:01,891 - Repacking signed builds in /Users/tomcat/partner-repacks/scripts/original_builds/21.0b5/build1/win32/en-US
2013-04-30 01:45:01,891 - Downloading from http://hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_21_0b5_RELEASE/browser/installer/windows/app.tag
2013-04-30 01:45:01,892 - To: app.tag
2013-04-30 01:45:01,892 - CWD: /Users/tomcat/partner-repacks/scripts
2013-04-30 01:45:02,152 - Error downloading http://hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_21_0b5_RELEASE/browser/installer/windows/app.tag
Traceback (most recent call last):
  File "./partner-repacks.py", line 491, in retrieveFile
    StrictFancyURLopener().retrieve(url, file_path)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 237, in retrieve
    fp = self.open(url, data)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 205, in open
    return getattr(self, name)(url)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 356, in open_http
    return self.http_error(url, fp, errcode, errmsg, headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 373, in http_error
    return self.http_error_default(url, fp, errcode, errmsg, headers)
  File "./partner-repacks.py", line 48, in http_error_default
    headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib.py", line 379, in http_error_default
    raise IOError, ('http error', errcode, errmsg, headers)
IOError: ('http error', 404, 'Not Found', <httplib.HTTPMessage instance at 0x10a1267a0>)
2013-04-30 01:45:02,154 - Cannot remove app.tag
Traceback (most recent call last):
  File "./partner-repacks.py", line 496, in retrieveFile
    os.remove(file_path)
OSError: [Errno 2] No such file or directory: 'app.tag'
2013-04-30 01:45:02,154 - Error: Unable to retrieve app.tag

Comment 1

[[e-mail] (:bhearsum)]

We'll need to parameterize the repo to make partner repacks possible in a beta. Kim or coop - can one of you grab this?

Comment 2

[Kim Moir [:kmoir] ET]

So the problem is that 
hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_21_0b5_RELEASE/browser/installer/windows/app.tag
is specified by default, but really should be 
hg.mozilla.org/releases/mozilla-beta/raw-file/FIREFOX_21_0b5_RELEASE/browser/installer/windows/app.tag

for betas, correct?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Kim Moir [:kmoir] from comment #2)
> So the problem is that 
> hg.mozilla.org/releases/mozilla-release/raw-file/FIREFOX_21_0b5_RELEASE/
> browser/installer/windows/app.tag
> is specified by default, but really should be 
> hg.mozilla.org/releases/mozilla-beta/raw-file/FIREFOX_21_0b5_RELEASE/browser/
> installer/windows/app.tag
> 
> for betas, correct?

Yep.

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: patch for buildbotcustom

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: buildbot-configs patch

I tested this on my dev master and added some debug statements, it prints out the correct values now

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: buildbot-configs patch

Comment 7

[[e-mail] (:bhearsum)]

Ugh, I don't know how I missed this before, but I just noticed that we're already passing "--repo" to partner-repacks.py:
python ./partner-repacks.py --version 20.0.1 --build-number 1 --repo releases/mozilla-release --hgroot http://hg.mozilla.org --staging-server stage.mozilla.org --dmg-extract-script /builds/slave/rel-m-rel-osx64_partner_rpk-00/tools/release/common/unpack-diskimage.sh --nightly-dir firefox/nightly --pkg-dmg /builds/slave/rel-m-rel-osx64_partner_rpk-00/partner-repacks/scripts/pkg-dmg --platform macosx64 --signed

Which means there's nothing we need to do here. I'm really sorry Kim, I hope you didn't spend much time on this :(.

Tomcat, when you're testing by hand you just need to pass "--repo releases/mozilla-beta" to make it work.

Comment 8

[Carsten Book [:Tomcat]]

verified, also updated the documentation

Comment 9

[Carsten Book [:Tomcat]]

(In reply to Ben Hearsum [:bhearsum] from comment #7)
> Ugh, I don't know how I missed this before, but I just noticed that we're
> already passing "--repo" to partner-repacks.py:
> python ./partner-repacks.py --version 20.0.1 --build-number 1 --repo
> releases/mozilla-release --hgroot http://hg.mozilla.org --staging-server
> stage.mozilla.org --dmg-extract-script
> /builds/slave/rel-m-rel-osx64_partner_rpk-00/tools/release/common/unpack-
> diskimage.sh --nightly-dir firefox/nightly --pkg-dmg
> /builds/slave/rel-m-rel-osx64_partner_rpk-00/partner-repacks/scripts/pkg-dmg
> --platform macosx64 --signed

btw was not even aware of that options, also now documented :)