Closed
Bug 867192
Opened 13 years ago
Closed 13 years ago
switch the finalised page injection order to head, then body, rather than body, then head
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Unassigned)
Details
Attachments
(1 file)
the code order causes confusion for people reading the code, let's keep the order 'intuitive' by first injecting OG into head, then the remix option into body, rather than the other way around.
Attachment #743661 -
Flags: review?(david.humphrey)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 743661 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/41
One perf suggestion, looks much better otherwise. Thanks for filing/fixing.
Attachment #743661 -
Flags: review?(david.humphrey) → review+
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 743661 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/41
Yup, land that, r+.
landed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•