86722 - UMR: in wvsprintfA

Status: VERIFIED WONTFIX

(Core Graveyard :: Plug-ins, defect, P5)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I think (I am not 100% sure) I got this UMR when giong to the site in the URL...

[W] UMR: Uninitialized memory read in wvsprintfA {1 occurrence}
        Reading 1 byte from 0x00139690 (1 byte at 0x00139690 uninitialized)
        Address 0x00139690 is argument #3 of wvsprintfA
        Address 0x00139690 points into a thread's stack 
        Address 0x00139690 is 4 bytes past the start of parameter 'format' in
dbgOut(char *,...)
        Thread ID: 0x558
        Error location
            wvsprintfA     [USER32.DLL]
            dbgOut(char *,...) [dbg.cpp:38]
                  lstrcat(buf, ": ");
                  va_list  va;
                  va_start(va, format);
             =>   wvsprintf(&buf[lstrlen(buf)], format, va);
                  va_end(va);
                  lstrcat(buf, "\n");
                  OutputDebugString(buf);
            NPP_SetWindow  [npshell.cpp:183]
                
                  if((pPlugin->getWindow() == NULL) && (hWnd != NULL))
                  { // First time in -- no window created by plugin yet
             =>     dbgOut1("NPP_SetWindow, first time");
                
                    if(!pPlugin->init(hWnd))
                    {
            ns4xPluginInstance::SetWindow(nsPluginWindow *)
[ns4xPluginInstance.cpp:769]
                
                    NS_TRY_SAFE_CALL_RETURN(error,
CallNPP_SetWindowProc(fCallbacks->setwindow,
                                                  &fNPP,
             =>                                   (NPWindow*) window), fLibrary);
                
                
                    // XXX In the old code, we'd just ignore any errors coming
            nsPluginHostImpl::InstantiateEmbededPlugin(char const*,nsIURI
*,nsIPluginInstanceOwner *) [nsPluginHostImpl.cpp:2903]
            nsObjectFrame::InstantiatePlugin(nsIPresContext
*,nsHTMLReflowMetrics&,nsHTMLReflowState const&,nsIPluginHost *,char
const*,nsIURI *) [nsObjectFrame.cpp:1075]
            nsObjectFrame::Reflow(nsIPresContext
*,nsHTMLReflowMetrics&,nsHTMLReflowState const&,UINT&) [nsObjectFrame.cpp:852]
            nsLineLayout::ReflowFrame(nsIFrame *,nsIFrame *
*,UINT&,nsHTMLReflowMetrics *,int&) [nsLineLayout.cpp:955]
           
nsBlockFrame::ReflowInlineFrame(nsBlockReflowState&,nsLineLayout&,nsLineBox
*,nsIFrame *,BYTE *) [nsBlockFrame.cpp:3459]
           
nsBlockFrame::DoReflowInlineFrames(nsBlockReflowState&,nsLineLayout&,nsLineBox
*,int *,BYTE *,int,int) [nsBlockFrame.cpp:3343]

Comment 1

[av (gone)]

This is in dbgOut call, a helper I wrote for debug builds only and which is 
used in the default plugin. Marking invalid.

Comment 2

[av (gone)]

Reopening as per conversation with heikki

Comment 3

[av (gone)]

Lowering priority as it is not affecting the release build. Likely a candidate 
for wontfix.

Comment 4

[rubydoo123]

marking as wontfix, this is specific to debug build, per plug-in triage team

Comment 5

[shrirang khanzode]

marking verif, pls reopen stating a reason, Thx!