Closed Bug 867293 Opened 11 years ago Closed 8 years ago

If multiple people are looking at an app, both should see it on their Reviewing list

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: adora, Unassigned)

Details

(Whiteboard: [repoman][marketplace-transition])

Current behavior appears to be that only the first person who opens the app page gets to see it on the Reviewing list.
How are you preventing multiple people reviewing the same app?
There is (or used to be) a warning on the page itself that another user was reviewing the app first.
Yeah, that's what I thought.  I thought the use case was:  User 1 opened a bunch of reviews in tabs, avoiding any that are locked.  Then user 2 opens a bunch of reviews in tabs avoiding any that are locked.

It sounds like this is saying multiple reviewers will be opening the same reviews.  Is that right?  What is the new use case?
(In reply to Wil Clouser [:clouserw] from comment #3)
> Yeah, that's what I thought.  I thought the use case was:  User 1 opened a
> bunch of reviews in tabs, avoiding any that are locked.  Then user 2 opens a
> bunch of reviews in tabs avoiding any that are locked.
> 
> It sounds like this is saying multiple reviewers will be opening the same
> reviews.  Is that right?  What is the new use case?

That's still the general use case for the original purpose of the flag - to avoid two reviewers attempting to review the same app.  However, we re-used the same flag for the 'reviewing queue' function which means once someone has an app's review page open no other reviewer opening the review page will see it in her/his 'reviewing queue' list.  Navigating to an exact review page on mobile is rather fiddly otherwise. 

So, the revised use cases would be:
- the second, or subsequent, reviewer to open a review page will see a flag in the queue indicating that another reviewer is looking at the page, and see a warning on the review page itself.
- the first, second, and all(*) subsequent reviewers will see the app listed in their 'reviewing queue' page on all devices when they open the review page on one device.  

(* if 'all' prevent an implementation problem, max 10 would probably do)
Priority: -- → P3
Whiteboard: [repoman]
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Whiteboard: [repoman] → [repoman][marketplace-transition]
You need to log in before you can comment on or make changes to this bug.