867296 - [login.wm.o] Remove port from audience environment variable

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: Login, defect)

Description

[Kieran Sedgwick (:sedge)]

The .env file contains two environment variables that are unnecessarily linked: 

PORT = 3000 (the default port for the login server)

and

AUDIENCE = ip:3000 (what will be displayed in the address bar, req. for persona)

Rather than hardcoding the port in two different ENV variables, we should put the combination in the code using a templating system, i.e.

var url = {% env.get('AUDIENCE') + env.get('PORT');

Comment 1

[Jon Buckley]

The port that the server is running on is not always the URL that it maps to. As an example, popcorn.wm.o is hosted on port 80. But we have a load balancer in front of the popcorn.wm.o servers that accepts SSL connections on port 443.

So the config looks like:

AUDIENCE=https://popcorn.webmaker.org
PORT=80

You wouldn't be able to do this configuration with a single environment variable.