Valgrind detects "Conditional jump or move depends on uninitialised value(s)" with mozilla::FrameLayerBuilder::BuildContainerLayerFor on the stack

NEW
Unassigned

Status

()

Core
Graphics: Layers
5 years ago
5 years ago

People

(Reporter: janv, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
I ran all dom/indexedDB mochitests under valgrind to find possible memory problems in regards to fix a crash in TransactionThreadPool, bug 855331.

The valgrind log is attached in the bug 855331. There are many mentions of mozilla::FrameLayerBuilder::BuildContainerLayerFor 

I'm not sure, but the crash could somehow relate to layers refactoring or multi threaded image decoding which landed about the same time as the centralized quota manager.

Also, one of the tbpl logs related to the crash shows:
###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gfx/layers/ipc/LayerTransactionChild.cpp, line 82
just before the crash, for example bug 859333, comment 70:
https://tbpl.mozilla.org/php/getParsedLog.php?id=22391193&tree=Birch

Not sure if it is just a false positive or real.

Updated

5 years ago
Component: Layout → Graphics: Layers

Comment 1

5 years ago
Jeff do you know who the right person to look into this is?
Flags: needinfo?(jmuizelaar)
(Reporter)

Comment 2

5 years ago
see also: https://tbpl.mozilla.org/php/getParsedLog.php?id=22677118&tree=Mozilla-Inbound&full=1#error0

"malloc: *** error for object 0x8000: pointer being freed was not allocated"
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> Jeff do you know who the right person to look into this is?

I do not. I had a look at this and it was obvious to me how to act.
Flags: needinfo?(jmuizelaar)

Comment 4

5 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> > Jeff do you know who the right person to look into this is?
> 
> I do not. I had a look at this and it was obvious to me how to act.

Not sure if I can parse this!  :-)  Do you mean you're going to investigate yourself?
Flags: needinfo?(jmuizelaar)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> > > Jeff do you know who the right person to look into this is?
> > 
> > I do not. I had a look at this and it was obvious to me how to act.
> 
> Not sure if I can parse this!  :-)  Do you mean you're going to investigate
> yourself?

I mean that I don't know who the right person is and I'm pretty sure it's not me.
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.