867408 - Ice candidates given to addIceCandidate should require either a mid or m-line index, but not both

Status: RESOLVED DUPLICATE of bug 823512

(Core :: WebRTC: Networking, defect, P3)

Description

[Jason Smith [:jsmith]]

Per IRC in addIceCandidate:

    if (!cand.candidate || !cand.sdpMLineIndex) {
      throw new Components.Exception("Invalid candidate passed to addIceCandidate!");
    }

This should be &&, not ||.

Comment 1

[Back Aug 24 [:jib]]

There's a second assumption here which is that valid sdpMLineIndex > 0, even though the spec says 0 is valid.

This invariant is currently guaranteed by the RTCIceCandidate constructor which adds +1, but while that works, it is wrong, because sdpMLineIndex is a readable, and apps reading it should get the same value they set.

Once we fix that (by pushing the +1 down into the implementation), then we'd want this condition to look more like this I think:

  if (!cand.candidate && cand.sdpMLineIndex === undefined) {
    throw new Components.Exception("Invalid candidate to addIceCandidate!");
  }

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Is this fixed/irrelevant?

Comment 3

[Back Aug 24 [:jib]]

Fixed here https://hg.mozilla.org/mozilla-central/rev/7e02515f7a1d#l7.456