867426 - GC: remove the Raw* typedefs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

With the static analysis in-place and working, the Raw typedefs are looking rather silly and vestigial. Removing them will reduce our type burden further and allow us to kill the ForwardDeclare macros with fire.

The following series of patches was constructed largely with find, grep, sed and a bunch of manual sanity checking. I think I caught all the places that would have thrown off spacing, but some thoughtful spot-checking would still probably be worthwhile.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v0: RawAtom

Comment 2

[Terrence Cole [:terrence]]

Attachment: v0: RawFlatString

Comment 3

[Terrence Cole [:terrence]]

Attachment: v0: RawLinearString

Comment 4

[Terrence Cole [:terrence]]

Attachment: v0: RawBaseShape

Comment 5

[Terrence Cole [:terrence]]

Attachment: v0: RawUnownedBaseShape

Comment 6

[Terrence Cole [:terrence]]

Attachment: v0: RawShape

Comment 7

[Terrence Cole [:terrence]]

Attachment: v0: RawInlineString

Comment 8

[Terrence Cole [:terrence]]

Attachment: v0: RawFunction

Comment 9

[Terrence Cole [:terrence]]

Attachment: v0: RawScript

Comment 10

[Terrence Cole [:terrence]]

Attachment: v0: RawString

Comment 11

[Terrence Cole [:terrence]]

Attachment: v0: RawValue

Comment 12

[Terrence Cole [:terrence]]

Attachment: v0: RawId

Comment 13

[Terrence Cole [:terrence]]

Attachment: v0: RawObject

Comment 14

[Terrence Cole [:terrence]]

Attachment: v0: Remove ForwardDeclare

Comment 15

[Terrence Cole [:terrence]]

In case some of these leaked into the browser in such a way that ack can't find them, try run is up at:
https://tbpl.mozilla.org/?tree=Try&rev=a100e01c2b6c

Comment 16

[Jon Coppeard (:jonco)]

Comment on attachment 743910 [details] [diff] [review]
v0: RawObject

Review of attachment 743910 [details] [diff] [review]:
-----------------------------------------------------------------

No problems with the patch, just a couple of incidental things I noticed:

::: js/src/gc/Marking.cpp
@@ +701,1 @@
>                                        const char *name)

We could fix the alignment here.

::: js/src/gc/RootMarking.cpp
@@ +488,5 @@
>        case OBJOBJHASHMAP: {
>          AutoObjectObjectHashMap::HashMapImpl &map = static_cast<AutoObjectObjectHashMap *>(this)->map;
>          for (AutoObjectObjectHashMap::Enum e(map); !e.empty(); e.popFront()) {
> +            mozilla::DebugOnly<JSObject *> key = e.front().key;
> +            MarkObjectRoot(trc, (JSObject **) &e.front().key, "AutoObjectObjectHashMap key");

Should we be using c++ casts here (and the following cases)?

Comment 17

[Terrence Cole [:terrence]]

Huzzah! It's not often one gets to physically kill one's own bad ideas.
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c4b69fcc7f
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72c4442a30e
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1025831aef
https://hg.mozilla.org/integration/mozilla-inbound/rev/c084cc59bbdf
https://hg.mozilla.org/integration/mozilla-inbound/rev/e119cde77a3b
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9cf4a647f39
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c8e389fd3c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1d2c16bee47
https://hg.mozilla.org/integration/mozilla-inbound/rev/a559bb362a2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/e578b67ec2fa
https://hg.mozilla.org/integration/mozilla-inbound/rev/566bd5b45961
https://hg.mozilla.org/integration/mozilla-inbound/rev/f234cb1b600e
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8fec8d2393
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa6176c9b03f
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fbf994a4b1f

A green build is at:
https://tbpl.mozilla.org/?tree=Try&rev=a100e01c2b6c
The debug bustage is totally unrelated.

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4fbf994a4b1f
https://hg.mozilla.org/mozilla-central/rev/fa6176c9b03f
https://hg.mozilla.org/mozilla-central/rev/3a8fec8d2393
https://hg.mozilla.org/mozilla-central/rev/f234cb1b600e
https://hg.mozilla.org/mozilla-central/rev/566bd5b45961
https://hg.mozilla.org/mozilla-central/rev/e578b67ec2fa
https://hg.mozilla.org/mozilla-central/rev/a559bb362a2b
https://hg.mozilla.org/mozilla-central/rev/b1d2c16bee47
https://hg.mozilla.org/mozilla-central/rev/8c8e389fd3c3
https://hg.mozilla.org/mozilla-central/rev/f9cf4a647f39
https://hg.mozilla.org/mozilla-central/rev/e119cde77a3b
https://hg.mozilla.org/mozilla-central/rev/c084cc59bbdf
https://hg.mozilla.org/mozilla-central/rev/7b1025831aef
https://hg.mozilla.org/mozilla-central/rev/f72c4442a30e
https://hg.mozilla.org/mozilla-central/rev/90c4b69fcc7f