867445 - remove test pilot from Firefox

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

It currently has a number of issues (bug 832703, bug 832705, bug 856867) that make it not a suitable solution for inclusion in Firefox by default (in beta builds).

The plan moving forward will be to address this by fixing bug 840108.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://tbpl.mozilla.org/?tree=Try&rev=64c42b2a640a

Comment 2

[(no longer active)]

You forgot to remove an endif.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 1: Remove testpilot-specific files

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 2: Remove references to Test Pilot in files that aren't specific to Test Pilot

Here is the try run (it isn't obvious, but this run does include these changes, as well as the change to remove nsIX509Cert.verifyForUsage):
https://tbpl.mozilla.org/?tree=Try&rev=015b6dd0e28b

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 744358 [details] [diff] [review]
Part 2: Remove references to Test Pilot in files that aren't specific to Test Pilot

In browser/app/profile/extensions/Makefile.in, basically everything in that file is now no longer necessary. I don't know whether we can remove it entirely or just have it be mostly empty, because I'm not sure how this stuff works now that we have moz.build files. A build peer (gps? glandium?) should advise.

We can also now remove the definition of SHIP_FEEDBACK in browser/installer/Makefile.in

There is also a reference to the "runStudies" prefs in addon-sdk/source/python-lib/cuddlefish/prefs.py that could be removed.

I'm not sure what the deal is with the android package-manifest.in reference, AFAIK this code wouldn't be built there so packaging would fail. But I guess that file probably isn't used? The same line is in b2g/installer/package-manifest.in, and I think it is equally bogus. They should just be removed, but it might be good to get a mobile person (mfinkle?) to confirm the bogosity.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 744358 [details] [diff] [review]
Part 2: Remove references to Test Pilot in files that aren't specific to Test Pilot

gps, mfinkle: see comment 5

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 744358 [details] [diff] [review]
Part 2: Remove references to Test Pilot in files that aren't specific to Test Pilot

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #5)
> In browser/app/profile/extensions/Makefile.in, basically everything in that
> file is now no longer necessary.

Actually, let's leave it for now. We'll likely need to re-add exactly the same logic when fixing bug 840108 (which might be soon), so it's probably best to just leave it as-is for now.

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 2: Remove references to Test Pilot in files that aren't specific to Test Pilot

Comment 9

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1678abc3a8b

I folded both patches together into one patch.

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e1678abc3a8b

Comment 11

[Mike Hommey [:glandium]]

Considering bug 842334 comment 10, should we get this on beta? Or simply not care?

Comment 12

[:Gavin Sharp [email: [e-mail]]]

I think you meant to reference bug 842334 comment 110. I'm inclined to just not care, we will fix it when we re-introduce test pilot 2 (bug 872680).

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

This has been noted in the Aurora 23 release notes:

http://www.mozilla.org/en-US/firefox/23.0a2/auroranotes/

If you would like to make any changes or have questions/concerns please contact me directly.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

I noted this on IRC, but want to make sure it's being tracked properly: this is only relevant to Aurora/Beta builds, so it's not something that we want to release note for 23 when it is released.

(I'm not even sure it's worth relnoting at all, so it may just be easier to remove the relnote entirely? I don't feel strongly.)

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

I'm fine with removing the relnote, since this will be staying away from release populations.

Comment 16

[u279076]

Adding this to the sign-off criteria for Firefox 23.0b1.

Comment 17

[Ada [:adalucinet]]

Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130520 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130619 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:23.0) Gecko/20130619 Firefox/23.0

The Test Pilot is not present in Addons->Extensions with Aurora 23.0a2 (Build ID: 20130619004018). Although, if I update an Aurora version where the Test Pilot is enabled, but after applying updates it isn't disabled in Extensions. Is it expected?

Comment 18

[u279076]

I believe this is expected. The change above removes it from new installations only. It's not meant to rip it out of existing installs. Brian, can you please confirm this assumption?

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Yes, that's right.

Comment 20

[u279076]

Thanks Gavin, marking verified fixed.