Closed Bug 867485 Opened 8 years ago Closed 8 years ago

Move the devtools loader into toolkit

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: dcamp, Unassigned)

Details

(Whiteboard: [fixed-in-fx-team][for-reals-dont-back-out])

Attachments

(5 files)

v1
43.59 KB, patch
jwalker
: review+
Details | Diff | Splinter Review
v2
45.90 KB, patch
Details | Diff | Splinter Review
v2.1
3.11 KB, patch
jwalker
: review+
Details | Diff | Splinter Review
Fix typos
2.25 KB, patch
jwalker
: review+
Details | Diff | Splinter Review
Fix another typo
1.16 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
Attached patch v1 — — Splinter Review 
I feel bad about this - I put the loader in gDevTools.jsm in browser, but it clearly belongs in toolkit where it can be used to load the debugger server too.

https://tbpl.mozilla.org/?tree=Try&rev=0ee3c6f5602e
Attachment #744007 - Flags: review?(jwalker)
Comment on attachment 744007 [details] [diff] [review]
v1

Review of attachment 744007 [details] [diff] [review]:
-----------------------------------------------------------------

Orange to fix, but r+ otherwise
Attachment #744007 - Flags: review?(jwalker) → review+
I'm lame, backed out.
Whiteboard: [fixed-in-fx-team]
Attached patch v2 — — Splinter Review
Attached patch v2.1 — — Splinter Review 
v2 is v1 with orange fixes (just s/gDevtools.jsm/Loader.jsm/ in a few missed places).

v2 fixes some references to gDevTools from Loader.jsm.
Attachment #744349 - Flags: review?(jwalker)
(In reply to Dave Camp (:dcamp) from comment #5)

> v2 fixes some references to gDevTools from Loader.jsm.

err, v2.1.

I'm going to stop using bugzilla and mercurial today.
Attachment #744349 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/integration/fx-team/rev/23422beddf5e
Whiteboard: [fixed-in-fx-team][for-reals-dont-back-out]
Attached patch Fix typos — — Splinter Review 
I don't know why no tests failed, but I can't open the tools locally without this patch.
Attachment #749184 - Flags: review?(dcamp)
Attachment #749184 - Flags: review?(dcamp) → review+
(In reply to Panos Astithas [:past] from comment #8)
> I don't know why no tests failed, but I can't open the tools locally without
> this patch.

My theory was that the test harness had somehow loaded the missing libraries by the time the devtools tests ran, but check this out: my Lion build of fx-team tip (on my 2nd PC) had no problems running even without my fix!

Sometimes I really hate computers.
Attached patch Fix another typo — — Splinter Review 
You'd think I would have caught that in my previous fix, but nooooooo...
Attachment #749860 - Flags: review?(jwalker)
Attachment #749860 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/mozilla-central/rev/23422beddf5e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.