867485 - Move the devtools loader into toolkit

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

I feel bad about this - I put the loader in gDevTools.jsm in browser, but it clearly belongs in toolkit where it can be used to load the debugger server too.

https://tbpl.mozilla.org/?tree=Try&rev=0ee3c6f5602e

Comment 1

[Joe Walker [:jwalker]]

Comment on attachment 744007 [details] [diff] [review]
v1

Review of attachment 744007 [details] [diff] [review]:
-----------------------------------------------------------------

Orange to fix, but r+ otherwise

Comment 2

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/9c204e0c1af1

Comment 3

[Dave Camp (:dcamp)]

I'm lame, backed out.

Comment 4

[Dave Camp (:dcamp)]

Attachment: v2

Comment 5

[Dave Camp (:dcamp)]

Attachment: v2.1

v2 is v1 with orange fixes (just s/gDevtools.jsm/Loader.jsm/ in a few missed places).

v2 fixes some references to gDevTools from Loader.jsm.

Comment 6

[Dave Camp (:dcamp)]

(In reply to Dave Camp (:dcamp) from comment #5)

> v2 fixes some references to gDevTools from Loader.jsm.

err, v2.1.

I'm going to stop using bugzilla and mercurial today.

Comment 7

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/23422beddf5e

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Fix typos

I don't know why no tests failed, but I can't open the tools locally without this patch.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/965fa67fc410

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Panos Astithas [:past] from comment #8)
> I don't know why no tests failed, but I can't open the tools locally without
> this patch.

My theory was that the test harness had somehow loaded the missing libraries by the time the devtools tests ran, but check this out: my Lion build of fx-team tip (on my 2nd PC) had no problems running even without my fix!

Sometimes I really hate computers.

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Fix another typo

You'd think I would have caught that in my previous fix, but nooooooo...

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/36cd40523c3a

Comment 13

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/23422beddf5e

Comment 14

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/965fa67fc410
https://hg.mozilla.org/mozilla-central/rev/36cd40523c3a