Closed
Bug 867485
Opened 8 years ago
Closed 8 years ago
Move the devtools loader into toolkit
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: dcamp, Unassigned)
Details
(Whiteboard: [fixed-in-fx-team][for-reals-dont-back-out])
Attachments
(5 files)
43.59 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
45.90 KB,
patch
|
Details | Diff | Splinter Review | |
3.11 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
2.25 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
I feel bad about this - I put the loader in gDevTools.jsm in browser, but it clearly belongs in toolkit where it can be used to load the debugger server too. https://tbpl.mozilla.org/?tree=Try&rev=0ee3c6f5602e
Attachment #744007 -
Flags: review?(jwalker)
Comment 1•8 years ago
|
||
Comment on attachment 744007 [details] [diff] [review] v1 Review of attachment 744007 [details] [diff] [review]: ----------------------------------------------------------------- Orange to fix, but r+ otherwise
Attachment #744007 -
Flags: review?(jwalker) → review+
Reporter | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9c204e0c1af1
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Comment 4•8 years ago
|
||
Reporter | ||
Comment 5•8 years ago
|
||
v2 is v1 with orange fixes (just s/gDevtools.jsm/Loader.jsm/ in a few missed places). v2 fixes some references to gDevTools from Loader.jsm.
Attachment #744349 -
Flags: review?(jwalker)
Reporter | ||
Comment 6•8 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #5) > v2 fixes some references to gDevTools from Loader.jsm. err, v2.1. I'm going to stop using bugzilla and mercurial today.
Updated•8 years ago
|
Attachment #744349 -
Flags: review?(jwalker) → review+
Reporter | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/23422beddf5e
Whiteboard: [fixed-in-fx-team][for-reals-dont-back-out]
Comment 8•8 years ago
|
||
I don't know why no tests failed, but I can't open the tools locally without this patch.
Attachment #749184 -
Flags: review?(dcamp)
Updated•8 years ago
|
Attachment #749184 -
Flags: review?(dcamp) → review+
Comment 10•8 years ago
|
||
(In reply to Panos Astithas [:past] from comment #8) > I don't know why no tests failed, but I can't open the tools locally without > this patch. My theory was that the test harness had somehow loaded the missing libraries by the time the devtools tests ran, but check this out: my Lion build of fx-team tip (on my 2nd PC) had no problems running even without my fix! Sometimes I really hate computers.
Comment 11•8 years ago
|
||
You'd think I would have caught that in my previous fix, but nooooooo...
Attachment #749860 -
Flags: review?(jwalker)
Reporter | ||
Updated•8 years ago
|
Attachment #749860 -
Flags: review?(jwalker) → review+
Comment 13•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/23422beddf5e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Comment 14•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/965fa67fc410 https://hg.mozilla.org/mozilla-central/rev/36cd40523c3a
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•